[DAR-4672][External] Replaced no_legacy with legacy & swapped default scaling behaviour of NifTI importer
#958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiKlymchuk
approved these changes
Nov 5, 2024
JBWilkie
commented
Nov 7, 2024
| json.dump(input_data, f, indent=4) | ||
|
|
||
|
|
||
| def round_polygon_annotation_coordinates(annotation, decimal_places=2): |
Contributor
Author
There was a problem hiding this comment.
Necessary because we export coordinates with 4 decimal places of precision, but scaling annotations results in coordinates with many more decimal places. We therefore have to ensure 4 dp for the assertions to pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that
MED_2D_VIEWERhas been globally enabled, the default behaviour of theNifTIannotation importer should be not to scale annotationsSolution
NifTIannotation importer not to scale annotations isotropically upon import. This means annotations uploaded to postMED_2D_VIEWERfiles will be correct by default, but use of thelegacyflag will be needed when uploading to preMED_2D_VIEWERfilesno-legacywithlegacyeverywhere. Why? We had planned to do this eventually after the environment had stabilised withMED_2D_VIEWERglobally enabled, but we never go round to it.legacyis also a simpler concept to understand and work with thanno-legacyChangelog
Made the default behaviour of the
NifTIannotation importer more coherent with the state of Darwin