Skip to content

chore: update logback-classic to 1.4.14 [skip ci] #4776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2023
Merged

chore: update logback-classic to 1.4.14 [skip ci] #4776

merged 3 commits into from
Dec 4, 2023

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented Dec 4, 2023

No description provided.

knoobie
knoobie reviewed Dec 4, 2023
View reviewed changes
vaadin-spring-boot-starter/pom.xml
@@ -76,7 +76,7 @@
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.4.12</version>
<version>1.4.14</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy from the closed PR: Got another thing for you :) You should probably also add the other logback-* dependencies, otherwise you get a mismatch which is hard to debug: qos-ch/logback#744 (comment)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited
Loading

Dependencies Report

[Click for more Details]

knoobie
knoobie reviewed Dec 4, 2023
View reviewed changes
vaadin-spring-boot-starter/pom.xml
@@ -76,7 +76,7 @@
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.4.12</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have to remove the target/23.x labels because 23.x requires Spring Boot 2.7 where the baseline of logback is 1.2.x (https://github.com/spring-projects/spring-boot/blob/2.7.x/spring-boot-project/spring-boot-dependencies/build.gradle) A fix for the CVE was also added in 1.2.13 (qos-ch/logback#745)

@ZheSun88 ZheSun88 enabled auto-merge (squash) December 4, 2023 12:19
@ZheSun88 ZheSun88 merged commit 4cdfad8 into main Dec 4, 2023
@ZheSun88 ZheSun88 deleted the ZheSun88-patch-2 branch December 4, 2023 12:20
ZheSun88 added a commit that referenced this pull request Dec 4, 2023
@ZheSun88
chore: update logback-classic to 1.4.14 [skip ci] (#4776)
ec84da9 
* chore: update logback-classic to 1.4.14

* Update pom.xml
@vaadin-bot
Copy link
Contributor

Hi @ZheSun88 , this commit cannot be picked to 24.1 by this bot, can you take a look and pick it manually?

ZheSun88 added a commit that referenced this pull request Dec 4, 2023
@vaadin-bot @ZheSun88
chore: update logback-classic to 1.4.14 [skip ci] (#4776) (#4778)
c033534 
* chore: update logback-classic to 1.4.14

* Update pom.xml

Co-authored-by: Zhe Sun <[email protected]>
ZheSun88 added a commit that referenced this pull request Dec 7, 2023
@ZheSun88
chore: update logback-classic to 1.4.14 [skip ci] (#4776)
1b77482 
* chore: update logback-classic to 1.4.14

* Update pom.xml
ZheSun88 added a commit that referenced this pull request Dec 7, 2023
@vaadin-bot @ZheSun88 @manolo
chore : update dependency-check to use latest (#4731) (CP: 24.1) (#4789)
64eec63 
* chore : update dependency-check to use latest (#4731)

* chore: update dependency-check to use 9.0.0

* Update sbom.yml

* Update generateAndCheckSBOM.js

---------

Co-authored-by: Manuel Carrasco Moñino <[email protected]>

* update dependency to fix CVE-2023-6378 (#4759)

* chore: update logback-classic to 1.4.14 [skip ci] (#4776)

* chore: update logback-classic to 1.4.14

* Update pom.xml

---------

Co-authored-by: Zhe Sun <[email protected]>
Co-authored-by: Manuel Carrasco Moñino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knoobie knoobie knoobie left review comments

@vaadin-bot vaadin-bot vaadin-bot approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.2 need to pick manually 24.1 target/24.1 target/24.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZheSun88 @vaadin-bot @knoobie