fix failing tests after path-to-regexp 6.2.0 update #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 29, 2021 21:28
- since `path-to-regexp` 3.1.0 the way of passing options into the `tokensToFunction()` function has changed (see [#191](pillarjs/path-to-regexp#191)). - since `path-to-regexp` 4.0.0 the default exports have changed from a module object to individual functions (see [4.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v4.0.0)). - since `path-to-regexp` 5.0.0 the default value for the optional `encode` parameter in the `tokensToFunction()` function has changed (see [5.0.0](https://github.com/pillarjs/path-to-regexp/releases/tag/v5.0.0)). - since `path-to-regexp` 6.0.0 the `repeat` and `modifier` properties on route regexp keys were removed (see [#207](pillarjs/path-to-regexp#207)). The internals of the `@vaadin/router` package affected by these changes are updated so that the Vaadin Router public API remains unchanged.
In the ES module bundle the users may as well just import path-to-regexp themselves. In the UMD bundle, keep things 'as-is'.
vlukashov
force-pushed
the
vl/update-path-to-regexp
branch
from
bb8b4d2 to
c6b476f
Compare
haijian-vaadin
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up on #351
path-to-regexp3.1.0 the way of passing options into thetokensToFunction()function has changed (see #191).path-to-regexp4.0.0 the default exports have changed from a module object to individual functions (see 4.0.0).path-to-regexp5.0.0 the default value for the optionalencodeparameter in thetokensToFunction()function has changed (see 5.0.0).path-to-regexp6.0.0 therepeatandmodifierproperties on route regexp keys were removed (see #207).The internals of the
@vaadin/routerpackage affected by these changes are updated so that the Vaadin Router public API remains unchanged.