Skip to content

feat: port field component Lumo styles to CSS files #9250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
May 26, 2025
Merged

feat: port field component Lumo styles to CSS files #9250

merged 40 commits into from
May 26, 2025

Conversation

vursen
Copy link
Contributor

@vursen vursen commented May 22, 2025 •
edited
Loading

Description

The PR ports Lumo styles of the following field components from JS files to CSS files:

  • InputContainer
  • TextField
  • PasswordField
  • EmailField
  • NumberField
  • IntegerField
  • TextArea
  • ComboBox
  • MultiSelectComboBox
  • DatePicker
  • TimePicker

Select, CustomField and DateTimePicker will be covered in a separate PR

Depends on

Part of #9082

Type of change

  • Feature

vursen added 22 commits May 21, 2025 16:10
@vursen
chore: set up infrastructure for porting Lumo theme
a4738ff
@vursen
feat: port button Lumo styles to CSS files
f8e830c
@vursen
minimize diff
11a70fc
@vursen
fix: find root that is not a Vaadin component
8fd8365
@vursen
chore: disable test retry for ported Lumo visual tests
999a4c3
@vursen
fix: add CSSInjectionMixin to crud instead of changing logic
cf46386
@vursen
fix: add CSSInjectionMixin to crud instead of changing logic
76f199d
@vursen
chore: restore Lumo job name
c36888b
@vursen
fix CSS content check
9c82cbb
@vursen
use --theme=base instead of --base
4251d64
@vursen
improve gulpfile to generate fonts.css too
4e93560
@vursen
feat: port field component Lumo styles to CSS files
88ce7e1
@vursen
fix: add CSSInjectionMixin to select to fix snapshot tests
f54221a
@vursen
fix: guard against undefined styles in getEffectiveStyles
e17575a
@vursen
add copyright to icons.css
382e802
@vursen
add copyright to all css files
3c4c55e
@vursen
remove outdated comment
94cd347
@vursen
check for constructor.version instead of constructor.cssInjectProp
40644ec
@vursen
Merge branch 'v25_port-lumo-to-css-files_init' into v25_port-lumo-to-…
46633de 
…css-files_fields
@vursen
revert select changes
180639f
@vursen
add missing global styles
1c63181
@vursen
Merge branch 'v25_port-lumo-to-css-files_init' into v25_port-lumo-to-…
62b2bc2 
…css-files_fields
Base automatically changed from v25_port-lumo-to-css-files_init to main May 23, 2025 07:06
@vursen vursen marked this pull request as ready for review May 23, 2025 08:39
@vursen vursen requested a review from web-padawan May 23, 2025 08:40
web-padawan
web-padawan reviewed May 23, 2025
View reviewed changes
@vursen vursen requested a review from web-padawan May 23, 2025 13:22
@vursen vursen mentioned this pull request May 23, 2025
Merged
1 task
@vursen vursen force-pushed the v25_port-lumo-to-css-files_fields branch from 756bfad to d4bdded Compare May 26, 2025 06:10
web-padawan
web-padawan reviewed May 26, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 26, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vursen vursen merged commit bd77a30 into main May 26, 2025
10 checks passed
@vursen vursen deleted the v25_port-lumo-to-css-files_fields branch May 26, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vursen @web-padawan