Skip to content

fix: resize app layout drawer based on content #9261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

jouni
Copy link
Member

@jouni jouni commented May 22, 2025

Description

Allow the layout to react to drawer content size changes when drawer width is auto.

Before fix:

Screen.Recording.2025-05-22.at.15.41.09.mov

After fix:

Screen.Recording.2025-05-22.at.15.41.29.mov

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/pr
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Copy link

@web-padawan web-padawan merged commit 0fb1c7e into main May 23, 2025
9 checks passed
@web-padawan web-padawan deleted the app-layout-drawer-resize branch May 23, 2025 12:27
@vaadin-bot
Copy link
Collaborator

Hi @jouni and @web-padawan, when i performed cherry-pick to this commit to 24.6, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 0fb1c7e
error: could not apply 0fb1c7e... fix: resize app layout drawer based on content (#9261)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan pushed a commit that referenced this pull request May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants