-
Notifications
You must be signed in to change notification settings - Fork 12
feat(rln-wasm): porting the rln-wasm feature from v0.6.1 to v0.7.0 #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for d6c5bc2Click to view benchmark
|
- Use ark-circom wasm feature for WebAssembly target - Integrate rln.wasm file for witness calculation - Fix dependencies issues related to compatibility with ark-circom 0.5.0 - Bump dependencies versions across all modules - Update documentation
Benchmark for 07c9a5fClick to view benchmark
|
Benchmark for 07c9a5fClick to view benchmark
|
Benchmark for 07c9a5fClick to view benchmark
|
…asm-pack for CI
Benchmark for 832ffe6Click to view benchmark
|
Benchmark for 832ffe6Click to view benchmark
|
Benchmark for 832ffe6Click to view benchmark
|
…: `crate_type` within an `#![cfg_attr]` attribute is forbidden in CI
Benchmark for 220cdf4Click to view benchmark
|
Benchmark for 220cdf4Click to view benchmark
|
Benchmark for 220cdf4Click to view benchmark
|
…de.js version mismatch
Benchmark for 85f0021Click to view benchmark
|
Benchmark for 85f0021Click to view benchmark
|
Benchmark for 85f0021Click to view benchmark
|
…v var in wasm-pack build
Benchmark for b192991Click to view benchmark
|
Benchmark for b192991Click to view benchmark
|
…: `crate_type` within an `#![cfg_attr]` attribute is forbidden in CI again
Benchmark for b192991Click to view benchmark
|
Benchmark for 1071084Click to view benchmark
|
Benchmark for 1071084Click to view benchmark
|
Benchmark for 1071084Click to view benchmark
|
Benchmark for cb2e682Click to view benchmark
|
Benchmark for cb2e682Click to view benchmark
|
Benchmark for 9d4a7c5Click to view benchmark
|
seemenkina
reviewed
Apr 4, 2025
…ge, ignore bench/test in rln-cli, bump deps
Benchmark for 7d745f0Click to view benchmark
|
Benchmark for 7d745f0Click to view benchmark
|
Benchmark for 7d745f0Click to view benchmark
|
… remove vk_from_raw func, optimize normalize_usize func, use rln_witness_from_values and prepare_verify_input for rln-wasm test
Benchmark for 36873adClick to view benchmark
|
Benchmark for 36873adClick to view benchmark
|
Benchmark for 36873adClick to view benchmark
|
Benchmark for 64e1ce9Click to view benchmark
|
Benchmark for 64e1ce9Click to view benchmark
|
Benchmark for 64e1ce9Click to view benchmark
|
Benchmark for 894c64dClick to view benchmark
|
Benchmark for 894c64dClick to view benchmark
|
Benchmark for 894c64dClick to view benchmark
|
Benchmark for fe7a5fdClick to view benchmark
|
Benchmark for fe7a5fdClick to view benchmark
|
Benchmark for fe7a5fdClick to view benchmark
|
seemenkina
reviewed
Apr 8, 2025
Benchmark for 6f6c976Click to view benchmark
|
Benchmark for 6f6c976Click to view benchmark
|
Benchmark for 6f6c976Click to view benchmark
|
seemenkina
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring Back WebAssembly Support for ZeroKit on v0.8.0 #289
Vendorwasmer
v4.4.0 in my git repository forark-circom
v0.5.0.wasm-pack
build failures (os error 2
) caused by a Node.js version mismatch.rln-wasm
feature and update to the stable toolchain.Useark-circom
with thewasm
feature for WebAssembly compatibility and therln.wasm
file for witness calculation.Fix dependency issues related toark-circom
v0.5.0, which currently useswasmer
v4.4.0 and is affected by this issue.brew
andapt-get
instead of cloning to fixwasm-strip not found
issue in the CI workflow.wasm-pack
withcurl
instead of usingwasm-pack-action
to fix parse exception error in the CI workflow..wasm
file with JS bindings for witness calculation, which is generated fromiden3/circom
during circuit compilation. This allows witness computation outside RLN instance.rln
module by moving circuit-related files to thesrc/circuit
folder for better organization.ark-circom
andwasmer
by cloning the CircomReduction struct and the read_zkey function into therln
module, which reduces the repository's build size and speeds up compilation time and the CI workflow duration.wasmer
andwasmer-wasix
, which lack x32 system support.rln-wasm
withwasm_bindgen_test
, covering RLN instance creation, key generation, witness calculation, proving, and verification. Also, add them tov0.6.1
in benchmark-v0.6.1 for comparison.arkzkey
feature for rln-wasm, including tests, benchmarks, CI workflow updates, and related documentation.benchmark-v0.7.0
branch for later use here.repeat().take()
can be written more concisely" on CI workflow forutils
module. (error)make build
,make test
, andmake bench
from root and inside each modules.