Skip to content

feat(niceToHave): Export list of country codes that implement IBAN #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
profnandaa merged 5 commits into from
Jul 16, 2021
+10 −1
Merged

feat(niceToHave): Export list of country codes that implement IBAN #1669

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
827b423
feat(niceToHave): Export list of country codes that implement IBAN
drorHellerNielsen May 5, 2021
590cf79
Update src/index.js
drorheller May 5, 2021
d950276
fix(bug): Export isIBANLocales by its correct alias
drorHellerNielsen May 13, 2021
7123c94
fix(test): fix name change in test
drorHellerNielsen May 25, 2021
6006307
fix(standards): change members exported name
drorHellerNielsen Jul 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import isHSL from './lib/isHSL';

import isISRC from './lib/isISRC';

import isIBAN from './lib/isIBAN';
import isIBAN, { locales as isIBANLocales } from './lib/isIBAN';
Copy link
Member

@profnandaa profnandaa May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be calling them isIBANLocales could be a little misleading, might think it's a validator/function. Perhaps just drop the is?

Copy link
Contributor Author

@drorheller drorheller May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@profnandaa I see what you're saying, but I think it's more inline with the rest of the code to call it isIBANLocales

import isBIC from './lib/isBIC';

import isMD5 from './lib/isMD5';
Expand Down Expand Up @@ -222,6 +222,7 @@ const validator = {
isDate,
isLicensePlate,
isVAT,
isIBANLocales,
};

export default validator;
2 changes: 2 additions & 0 deletions src/lib/isIBAN.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,3 +135,5 @@ export default function isIBAN(str) {

return hasValidIbanFormat(str) && hasValidIbanChecksum(str);
}

export const locales = Object.keys(ibanRegexThroughCountryCode);
6 changes: 6 additions & 0 deletions test/exports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { locales as isAlphaLocales } from '../src/lib/isAlpha';
import { locales as isAlphanumericLocales } from '../src/lib/isAlphanumeric';
import { locales as isMobilePhoneLocales } from '../src/lib/isMobilePhone';
import { locales as isFloatLocales } from '../src/lib/isFloat';
import { locales as ibanCountryCodes } from '../src/lib/isIBAN';
Copy link
Contributor

@fedeci fedeci Jul 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { locales as ibanCountryCodes } from '../src/lib/isIBAN';
import { locales as isIBANLocales } from '../src/lib/isIBAN';

I would name it isIBANLocales to align to the other one.


describe('Exports', () => {
it('should export validators', () => {
Expand Down Expand Up @@ -50,4 +51,9 @@ describe('Exports', () => {
assert.ok(isFloatLocales instanceof Array);
assert.ok(validator.isFloatLocales instanceof Array);
});

it('should export a list of country codes that implement IBAN', () => {
assert.ok(ibanCountryCodes instanceof Array);
assert.ok(validator.ibanCountryCodes instanceof Array);
});
});