Skip to content

fix: remove using of includes to support IE #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Mar 28, 2025

Rebased version of #2099. This PR adds back support for IE.
Fixes #1272

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (991e5ac) to head (6edcb5a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2540   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         113      114    +1     
  Lines        2527     2535    +8     
  Branches      641      641           
=======================================
+ Hits         2526     2534    +8     
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WikiRik WikiRik requested a review from profnandaa April 8, 2025 17:16
@profnandaa profnandaa merged commit 791ef16 into master Apr 8, 2025
13 checks passed
@profnandaa profnandaa deleted the WikiRik/ie-support branch April 9, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String.prototype.includes() is not supported in IE
3 participants