Skip to content

feat(isLicensePlate): Updated isLicensePlate to accept real pt-PT license plates. #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025

Conversation

castrosu
Copy link
Contributor

I have updated the isLicensePlate pt-PT regex to accept actual valid license plates in Portugal.

Image as an example of valid license plates.
image

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8d58ecb) to head (c441418).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2555   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2535      2535           
  Branches       641       641           
=========================================
  Hits          2535      2535           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WikiRik
Copy link
Member

WikiRik commented Apr 19, 2025

Can you provide a link to the source where you made the screenshot from?

@castrosu
Copy link
Contributor Author

Can you provide a link to the source where you made the screenshot from?

Of course, here you go https://aran.pt/pt/matriculas-por-ano

@castrosu
Copy link
Contributor Author

can someone approve this? without this the current regex check doesn't pass all tests for pt-PT license plate in this PR

@WikiRik WikiRik requested a review from rubiin May 13, 2025 19:11
@rubiin rubiin merged commit 9e50384 into validatorjs:master May 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants