Skip to content

docs(connection): add password persistence hint in web mode and docker docs - #564

Open
RajGahoi wants to merge 1 commit into
valkey-io:mainfrom
RajGahoi:fix/web-mode-password-hint
Open

RajGahoi wants to merge 1 commit into
valkey-io:mainfrom
RajGahoi:fix/web-mode-password-hint

Conversation

@RajGahoi

Copy link
Copy Markdown
Contributor

Description

Closes #518

As discussed with maintainers in #518, web mode does not persist passwords in browser storage for security reasons.

This PR implements the maintainer suggested solution:

  1. Adds an inline advisory hint under the Password field in the ConnectionModal when running in web mode: 'Passwords aren't saved in web mode.'
  2. Adds a Password Persistence note in the Docker deployment documentation.

Testing

  • Passed npm run lint and frontend test suite.

Signed-off-by: Raj Gahoi gahoiraj01@gmail.com

…r docs

Clarifies that passwords are not saved in web mode for security reasons.

Closes valkey-io#518

Signed-off-by: Raj Gahoi <gahoiraj01@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b3a28211-1fd6-4bc5-8dd5-1b794e5764c6
📥 Commits

Reviewing files that changed from the base of the PR and between 0161e2a and c0c28c7.

📒 Files selected for processing: 2
  • apps/frontend/src/components/ui/connection-modal.tsx
  • docs-site/src/content/docs/deployment/docker.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added area/frontend UI components, state, routing area/docs Documentation site labels Oct 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Documentation site area/frontend UI components, state, routing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin password not saved in Valkey Admin connection settings

1 participant