Skip to content

Commit a9a126f

Browse files
avifeneshikolomi
authored andcommitted
Update supported languages and versions in configuration files, added… (#3606)
Update supported Node.js versions and improve package dependencies Signed-off-by: avifenesh <aviarchi1994@gmail.com>
1 parent d726934 commit a9a126f

File tree

9 files changed

+57
-51
lines changed

9 files changed

+57
-51
lines changed

.github/json_matrices/supported-languages-versions.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
},
1212
{
1313
"language": "node",
14-
"versions": ["16.x", "17.x", "18.x", "19.x", "20.x", "21.x", "22.x"],
15-
"always-run-versions": ["16.x", "22.x"]
14+
"versions": ["16.x", "18.x", "20.x", "22.x", "23.x"],
15+
"always-run-versions": ["18.x", "22.x"]
1616
},
1717
{
1818
"language": "dotnet",

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,3 +59,4 @@ generated/
5959
# docs
6060
docs/markdown/node/**
6161
docs/site/**
62+
copilot.yml

.vscode/settings.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
"editor.codeActionsOnSave": {
55
"source.organizeImports": "always"
66
},
7+
"rust-analyzer.procMacro.ignored": {
8+
"napi-derive": ["napi"]
9+
},
710
"editor.formatOnSave": true,
811
"files.insertFinalNewline": true,
912
"files.trimFinalNewlines": true,

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
* Core: Add an OK response type to FFI ([#3630](https://github.com/valkey-io/valkey-glide/pull/3630))
44
* Core: Move UDS Socket Filename to tmp ([#3615](https://github.com/valkey-io/valkey-glide/pull/3615))
5+
* Node: Added build improvements for rust release ([#3606](https://github.com/valkey-io/valkey-glide/pull/3606))
56
* Core: Ensure UDS socket filename is truly unique. ([#3596](https://github.com/valkey-io/valkey-glide/pull/3596))
67
* Node: Fix type declarations ([#3489](https://github.com/valkey-io/valkey-glide/pull/3489))
78
* Core: Add `opentelemetry` protocols support ([#3191](https://github.com/valkey-io/valkey-glide/pull/3191))

node/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ Alpine:
3232

3333
## NodeJS supported version
3434

35-
Node.js 16.20 or higher.
36-
35+
Node.js 16 or higher.
3736

3837
### Building & Testing
3938

node/package.json

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
"homepage": "https://github.com/valkey-io/valkey-glide#readme",
1313
"dependencies": {
1414
"glide-rs": "file:rust-client",
15-
"long": "^5.3.0",
16-
"protobufjs": "^7.4.0"
15+
"long": "5",
16+
"protobufjs": "7"
1717
},
1818
"bundleDependencies": [
1919
"glide-rs"
@@ -48,25 +48,25 @@
4848
"prettier:format": "npx prettier --write . --ignore-unknown '!**/*.{js,d.ts}'"
4949
},
5050
"devDependencies": {
51-
"@jest/globals": "^29.7.0",
52-
"@types/jest": "^29.5.14",
53-
"@types/minimist": "^1.2.5",
54-
"@types/redis-server": "^1.2.2",
55-
"@types/semver": "^7.5.8",
51+
"@jest/globals": "^29",
52+
"@types/jest": "^29",
53+
"@types/minimist": "^1",
54+
"@types/redis-server": "^1",
55+
"@types/semver": "^7",
5656
"@types/uuid": "^10.0.0",
5757
"find-free-port": "^2.0.0",
58-
"jest": "^29.7.0",
59-
"jest-html-reporter": "^3.10.2",
60-
"npmignore": "^0.3.1",
61-
"protobufjs-cli": "^1.1.3",
62-
"replace": "^1.2.2",
63-
"semver": "7.7.1",
64-
"ts-jest": "^29.2.5",
65-
"ts-node": "^10.9.2",
66-
"typedoc": "^0.28.2",
67-
"typedoc-plugin-markdown": "^4.4.1",
68-
"typescript": "^5.6.3",
69-
"uuid": "^11.0.3"
58+
"jest": "29",
59+
"jest-html-reporter": "4",
60+
"npmignore": "0.3",
61+
"protobufjs-cli": "1",
62+
"replace": "1",
63+
"semver": "7",
64+
"ts-jest": "29",
65+
"ts-node": "10",
66+
"typedoc": "0.28",
67+
"typedoc-plugin-markdown": "4",
68+
"typescript": "5",
69+
"uuid": "11"
7070
},
7171
"author": "Valkey GLIDE Maintainers",
7272
"license": "Apache-2.0",
@@ -100,5 +100,6 @@
100100
"${node_os}"
101101
],
102102
"///name": "${scope}${pkg_name}",
103-
"///version": "${package_version}"
103+
"///version": "${package_version}",
104+
"//libc": "${libc}"
104105
}

node/rust-client/Cargo.toml

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,25 @@ crate-type = ["cdylib"]
1414
redis = { path = "../../glide-core/redis-rs/redis", features = ["aio", "tokio-comp", "tokio-rustls-comp"] }
1515
glide-core = { path = "../../glide-core", features = ["socket-layer"] }
1616
tokio = { version = "1", features = ["rt", "macros", "rt-multi-thread", "time"] }
17-
napi = {version = "2.14", features = ["napi4", "napi6"] }
18-
napi-derive = "2.14"
17+
napi = {version = "2", features = ["napi8"] }
18+
napi-derive = "2"
1919
logger_core = {path = "../../logger_core"}
20-
byteorder = "1.4.3"
20+
byteorder = "1"
2121
bytes = "1"
22-
num-traits = "0.2.17"
23-
num-bigint = { version = "0.4.4", optional = true }
22+
num-traits = "0.2"
23+
num-bigint = { version = "0.4", optional = true }
2424
[target.'cfg(not(target_env = "msvc"))'.dependencies]
25-
tikv-jemallocator = {version = "0.5.4", features = ["disable_initial_exec_tls"] }
25+
tikv-jemallocator = {version = "0.6", features = ["disable_initial_exec_tls"] }
2626

2727
[build-dependencies]
28-
napi-build = "2.0.1"
28+
napi-build = "2"
2929

3030
[profile.release]
31-
lto = true
32-
debug = true
31+
opt-level = 3 # Optimize for performance
32+
lto = "fat" # Enable the most aggressive Link Time Optimization
33+
codegen-units = 1 # Reduce the number of code generation units, increasing optimization time but improving performance
34+
panic = "abort" # Use 'abort' instead of 'unwind' for panic handling
35+
strip = "symbols" # Remove symbol
3336

3437
[features]
3538
testing_utilities = ["num-bigint"]

node/rust-client/package.json

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,11 @@
1515
"defaults": true,
1616
"additional": [
1717
"x86_64-unknown-linux-musl",
18+
"x86_64-unknown-linux-gnu",
1819
"aarch64-unknown-linux-gnu",
19-
"armv7-unknown-linux-gnueabihf",
2020
"aarch64-apple-darwin",
21-
"aarch64-linux-android",
22-
"x86_64-unknown-freebsd",
23-
"aarch64-unknown-linux-musl",
24-
"armv7-linux-androideabi"
21+
"x86_64-apple-darwin",
22+
"aarch64-unknown-linux-musl"
2523
]
2624
}
2725
},
@@ -45,9 +43,9 @@
4543
"globals": "npm install --global @napi-rs/cli prettier"
4644
},
4745
"devDependencies": {
48-
"@napi-rs/cli": "^2.18.4",
49-
"lint-staged": "^15.2.10",
50-
"prettier": "^3.3.3"
46+
"@napi-rs/cli": "2",
47+
"lint-staged": "15",
48+
"prettier": "3"
5149
},
5250
"lint-staged": {
5351
"*.@(js|ts|tsx)": [

package.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
{
22
"devDependencies": {
3-
"@eslint/js": "9.17.0",
4-
"@types/eslint__js": "^8.42.3",
5-
"@types/eslint-config-prettier": "^6.11.3",
6-
"eslint": "9.17.0",
7-
"eslint-config-prettier": "^9.1.0",
8-
"eslint-plugin-jsdoc": "^50.6.1",
9-
"prettier": "3.4.2",
10-
"prettier-eslint": "16.3.0",
11-
"typescript": "5.7.2",
12-
"typescript-eslint": "8.18.1"
3+
"@eslint/js": "9",
4+
"@types/eslint__js": "8",
5+
"@types/eslint-config-prettier": "6",
6+
"eslint": "9",
7+
"eslint-config-prettier": "9",
8+
"eslint-plugin-jsdoc": "50",
9+
"prettier": "3",
10+
"prettier-eslint": "16",
11+
"typescript": "5",
12+
"typescript-eslint": "8"
1313
}
1414
}

0 commit comments

Comments
 (0)