Skip to content

Update supported languages and versions in configuration files, added…#3606

Merged
avifenesh merged 1 commit intovalkey-io:mainfrom
avifenesh:enhance-node-and-fix
Apr 27, 2025
Merged

Update supported languages and versions in configuration files, added…#3606
avifenesh merged 1 commit intovalkey-io:mainfrom
avifenesh:enhance-node-and-fix

Conversation

@avifenesh
Copy link
Copy Markdown
Member

@avifenesh avifenesh commented Apr 15, 2025

… release conf enhancements for node.

Issue link

This pull request includes multiple changes to update dependencies and configuration files across the project. The most important changes involve updating version constraints for dependencies, modifying the Cargo.toml configuration, and adjusting supported platform targets.

Dependency updates:

  • node/package.json: Updated version constraints for various dependencies and devDependencies to follow the major for avoiding breaks, but stay up to date with fixes and improvments. [1] [2]

Configuration updates:

  • node/rust-client/Cargo.toml: Updated version constraints for several dependencies and modified the release profile to optimize for size and performance.
    The results are half size binary, and 4% performance improvements.
    Platform target adjustments:

  • node/rust-client/package.json: Adjusted the list of additional platform targets for the Rust client, adding and removing specific targets.
    The removed targets are not supported by glide and redundant.

Supported languages and versions:

  • .github/json_matrices/supported-languages-versions.json: Updated the list of supported Node.js versions and adjusted the always-run versions.
    Odd versions have short life supports, and the convention is that the even versions are the stable. The latest odd is the only one we should spend CI time on, while extending our ability to keep support long term versions.

Additional configuration:

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@avifenesh avifenesh requested a review from a team as a code owner April 15, 2025 12:06
@avifenesh avifenesh force-pushed the enhance-node-and-fix branch from 62c9768 to ad48d7c Compare April 15, 2025 12:16
@avifenesh avifenesh added node 🐢 Node.js wrapper Optimization 🐌 Optimization matter such as cleaner code, performance etc CI/CD ⚒️ CI/CD related Platforms 🧱 Platforms support related issues and fixes 2_0_candidate labels Apr 15, 2025
@avifenesh avifenesh added this to the 2.0 milestone Apr 15, 2025
@avifenesh avifenesh force-pushed the enhance-node-and-fix branch 3 times, most recently from 622d83b to 88429bf Compare April 23, 2025 12:11
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
@avifenesh avifenesh force-pushed the enhance-node-and-fix branch from c76e841 to bc5a92a Compare April 27, 2025 09:31
@avifenesh avifenesh merged commit b6c3d46 into valkey-io:main Apr 27, 2025
61 of 63 checks passed
@avifenesh avifenesh deleted the enhance-node-and-fix branch April 27, 2025 10:42
@avifenesh avifenesh mentioned this pull request Apr 27, 2025
avifenesh added a commit that referenced this pull request May 2, 2025
#3606)

Update supported Node.js versions and improve package dependencies

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
(cherry picked from commit b6c3d46)
Signed-off-by: Avi Fenesh <aviarchi1995@gmail.com>
@avifenesh avifenesh modified the milestones: 2.0, 1.3.3 May 2, 2025
ikolomi pushed a commit that referenced this pull request May 11, 2025
#3606)

Update supported Node.js versions and improve package dependencies

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD ⚒️ CI/CD related node 🐢 Node.js wrapper Optimization 🐌 Optimization matter such as cleaner code, performance etc Platforms 🧱 Platforms support related issues and fixes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants