Node: added zpopmin command.#1008
Merged
adanWattad merged 1 commit intovalkey-io:mainfrom Feb 21, 2024
Merged
Conversation
barshaul
reviewed
Feb 21, 2024
node/src/Commands.ts
Outdated
| * @internal | ||
| */ | ||
| export function createZpopmin(key: string, count?: number): redis_request.Command { | ||
| return createCommand(RequestType.ZPopMin, [key, count ? count.toString() : "1"]); |
Collaborator
There was a problem hiding this comment.
if count is undefined, we don't want to pass "1", but instead to pass only they key. This way, if redis changes its default count value it won't break us
adanWattad
force-pushed
the
node/zpopmin
branch
from
04d3cdd to
a7412e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.