Node: added sismember command.#1083
Merged
adanWattad merged 1 commit intovalkey-io:mainfrom Mar 7, 2024
Merged
Conversation
adanWattad
force-pushed
the
node/sismember
branch
from
ce46ae5 to
b26e5e0
Compare
shohamazon
approved these changes
Mar 6, 2024
CHANGELOG.md
Outdated
| * Node: Allow routing Cluster requests by address. ([#1021](https://github.com/aws/glide-for-redis/pull/1021)) | ||
| * Python: Added HSETNX command. ([#954](https://github.com/aws/glide-for-redis/pull/954)) | ||
| * Python: Added SISMEMBER command ([#971](https://github.com/aws/glide-for-redis/pull/971)) | ||
| * Python, Node: Added SISMEMBER command ([#971](https://github.com/aws/glide-for-redis/pull/971), [#1083](https://github.com/aws/glide-for-redis/pull/1083)) |
Collaborator
There was a problem hiding this comment.
Python- it's actually 972
node/src/BaseClient.ts
Outdated
| /** Returns if `member` is a member of the set stored at `key`. | ||
| * See https://redis.io/commands/sismember/ for more details. | ||
| * | ||
| * @param key - The key to return the number of its members. |
Collaborator
There was a problem hiding this comment.
key - The key of the set.
node/src/BaseClient.ts
Outdated
| * | ||
| * @param key - The key to return the number of its members. | ||
| * @param member - The member to check for existence in the set. | ||
| * @returns true if the member exists in the set, false otherwise. |
node/src/BaseClient.ts
Outdated
| * @param key - The key to return the number of its members. | ||
| * @param member - The member to check for existence in the set. | ||
| * @returns true if the member exists in the set, false otherwise. | ||
| * If `key` doesn't exist, it is treated as an empty set and the command returns false. |
| return this.addAndReturn(createSCard(key)); | ||
| } | ||
|
|
||
| /** Returns if `member` is a member of the set stored at `key`. |
Yury-Fridlyand
approved these changes
Mar 6, 2024
| return this.createWritePromise(createSCard(key)); | ||
| } | ||
|
|
||
| /** Returns if `member` is a member of the set stored at `key`. |
There was a problem hiding this comment.
Suggested change
| /** Returns if `member` is a member of the set stored at `key`. | |
| /** Returns whether `member` is a member of the set stored at `key`. |
| * @param member - The member to check for existence in the set. | ||
| * @returns true if the member exists in the set, false otherwise. | ||
| * If `key` doesn't exist, it is treated as an empty set and the command returns false. | ||
| */ |
There was a problem hiding this comment.
What if key exists, but it is not a set?
Contributor
Author
There was a problem hiding this comment.
It will throw an error, but we decided not to document this error (see other set commands).
node/tests/SharedTests.ts
Outdated
| await client.sismember(key, "nonExistingMember") | ||
| ).toEqual(false); | ||
| expect( | ||
| await client.sismember("nonExistingKey", "member1") |
There was a problem hiding this comment.
Add a test when key exists, but it is not a set
adanWattad
force-pushed
the
node/sismember
branch
from
b26e5e0 to
477db9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.