Python: Add Script commands#2208
Merged
tjzhang-BQ merged 11 commits intovalkey-io:mainfrom Sep 9, 2024
Merged
Conversation
tjzhang-BQ
force-pushed
the
python/VALKEY-187-script-flush
branch
2 times, most recently
from
78ef000 to
a735a8d
Compare
tjzhang-BQ
force-pushed
the
python/VALKEY-187-script-flush
branch
from
65c6cb5 to
0147334
Compare
tjzhang-BQ
force-pushed
the
python/VALKEY-187-script-flush
branch
3 times, most recently
from
b2b699b to
2cd39fe
Compare
shohamazon
reviewed
Sep 5, 2024
| case the client will route the command to the nodes defined by `route`. Defaults to None. | ||
|
|
||
| Returns: | ||
| List[bool]: A list of boolean values indicating the existence of each script. |
Collaborator
There was a problem hiding this comment.
Suggested change
| List[bool]: A list of boolean values indicating the existence of each script. | |
| TClusterResponse[List[bool]]: A list of boolean values indicating the existence of each script. | |
| When specifying a route other than a single node, response will be: | |
| {Address (bytes) : response (List[bool]) , ... } with type of Dict[bytes, List[bool]]. |
Collaborator
There was a problem hiding this comment.
are we sure this is the response type? when you specify all nodes ?
Contributor
Author
There was a problem hiding this comment.
I believe if we specify to all nodes, the results across different nodes are just aggregated using a logical AND, according to cluster_routing.rs in redis.rs, and still returns a list of booleans.
shohamazon
reviewed
Sep 5, 2024
tjzhang-BQ
force-pushed
the
python/VALKEY-187-script-flush
branch
from
3b25b91 to
1a21f57
Compare
acarbonetto
approved these changes
Sep 6, 2024
tjzhang-BQ
force-pushed
the
python/VALKEY-187-script-flush
branch
from
d2efeb2 to
97e537c
Compare
jonathanl-bq
approved these changes
Sep 6, 2024
Contributor
jonathanl-bq
left a comment
jonathanl-bq
left a comment
There was a problem hiding this comment.
Spotted some small documentation mistakes. Please fix those first.
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
tjzhang-BQ
force-pushed
the
python/VALKEY-187-script-flush
branch
from
522e4fd to
30969fc
Compare
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Yury-Fridlyand
approved these changes
Sep 9, 2024
janhavigupta007
pushed a commit
to janhavigupta007/glide-for-redis
that referenced
this pull request
Sep 11, 2024
* Python: Add Script commands Signed-off-by: TJ Zhang <tj.zhang@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inheriting the changes from PR: #2094 & addressing existing comments
putting transactions out of scope for this PR since script_invocation and script_invocation_pointers seem to be parallel with transactions and more investigation might be needed for the implementation of invoke_script.