Java: Fix byte GlideString conversion to String bug#2271
Merged
GumpacG merged 7 commits intovalkey-io:mainfrom Sep 11, 2024
Merged
Java: Fix byte GlideString conversion to String bug#2271GumpacG merged 7 commits intovalkey-io:mainfrom
GumpacG merged 7 commits intovalkey-io:mainfrom
Conversation
3612356 to
4536917
Compare
acarbonetto
reviewed
Sep 11, 2024
acarbonetto
reviewed
Sep 11, 2024
4536917 to
d8d1ae2
Compare
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
4a14bbc to
8b614fb
Compare
acarbonetto
approved these changes
Sep 11, 2024
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
jonathanl-bq
approved these changes
Sep 11, 2024
Yury-Fridlyand
approved these changes
Sep 11, 2024
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
Please list which APIs (commands) you fixed in the PR description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug that incorrectly converts non UTF-8 bytes GlideString to String with the value
"Value not convertible to string: byte[] "instead of throwing an exception.Affected APIs:
convertMapToKeyValueGlideStringArray:
public CompletableFuture<String> msetBinary(@NonNull Map<GlideString, GlideString> keyValueMap)public CompletableFuture<Long> hset( @NonNull GlideString key, @NonNull Map<GlideString, GlideString> fieldValueMap)public CompletableFuture<GlideString> xadd( @NonNull GlideString key, @NonNull Map<GlideString, GlideString> values, @NonNull StreamAddOptionsBinary options)public CompletableFuture<Boolean> msetnxBinary( @NonNull Map<GlideString, GlideString> keyValueMap)convertNestedArrayToKeyValueGlideStringArray:
public CompletableFuture<GlideString> xadd( @NonNull GlideString key, @NonNull GlideString[][] values, @NonNull StreamAddOptionsBinary options)convertMapToValueKeyStringArrayBinary:
public CompletableFuture<Long> zadd( @NonNull GlideString key, @NonNull Map<GlideString, Double> membersScoresMap, @NonNull ZAddOptions options, boolean changed)Reproduction steps for the bug:
Run
See the output to be
Value not convertible to string: byte[] 13Expected
We expect an exception to be thrown in order to avoid unintended data to be stored in the server.