-
Notifications
You must be signed in to change notification settings - Fork 150
Java: Create Workflow to deploy artifacts for all platforms mentioned in build.matrix.json #2285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 41 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
e6188ae
testing out all platforms t1
cyip10 b1f18ce
uncomment first part of java-cd
cyip10 3839dea
comment out environment
cyip10 fb0d1f3
add java version
cyip10 7f1a623
fix java version placement
cyip10 7d5e376
change build.gradle
cyip10 d0203a1
change build.gradle
cyip10 20cb31a
remove application
cyip10 8c81419
add classifiers to benchmarks
cyip10 9a81f32
change examples build file
cyip10 5b95d79
remove export
cyip10 537eef6
check
cyip10 8b99070
remove commented out code
cyip10 1b5b5a7
fix
cyip10 a1a5f98
add release version
cyip10 b56319c
new v
cyip10 ffc41e4
change benchmark gradle
cyip10 879845a
add classifiers
cyip10 ff886c5
check redis
cyip10 8b11fdb
remove unnecessary file
cyip10 111f8a5
check redis
cyip10 6addb84
fix parse error
cyip10 136aee6
fix parse error
cyip10 ebab9bc
fix parse error
cyip10 5ca9b12
add redis
cyip10 d4afea9
add env variable
cyip10 17854b1
add validation fail part
cyip10 6fb0bc0
include steps
cyip10 c9db9a0
fix spacing
cyip10 edac22e
add runs on
cyip10 b7bcde5
add needs part
cyip10 75a6411
add deployment ID
cyip10 57657eb
add verbose line
cyip10 1be621e
clean up file
cyip10 8fc27ba
fix spacing
cyip10 b52757d
Merge branch 'main' into CI/maven_testing
cyip10 5cd3427
address comments, revert files, add back in missing test
cyip10 dcee12d
remove extra line
cyip10 c0ab2e7
change publish release to maven to follow order procedure
cyip10 bfb8d48
change to valkey server
cyip10 7528b4f
Merge branch 'main' into CI/maven_testing
cyip10 e7ef670
add changelog
cyip10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| plugins { | ||
| // Apply the application plugin to add support for building a CLI application in Java. | ||
| id 'application' | ||
| id "com.google.osdetector" version "1.7.3" | ||
| } | ||
|
|
||
| repositories { | ||
|
|
@@ -12,7 +13,7 @@ dependencies { | |
| def releaseVersion = System.getenv("GLIDE_RELEASE_VERSION"); | ||
|
|
||
| if (releaseVersion) { | ||
| implementation "io.valkey:valkey-glide:" + releaseVersion | ||
| implementation "io.valkey:valkey-glide:" + releaseVersion + ":${osdetector.classifier}" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🌟 |
||
| } else { | ||
| implementation project(':client') | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok - fine. good enough.