Python: adds JSON.ARRLEN command by shohamazon · Pull Request #2403 · valkey-io/valkey-glide

shohamazon · 2024-10-08T09:31:45Z

No description provided.

shohamazon · 2024-10-09T11:47:50Z

python/python/glide/async_commands/server_modules/json.py

+            For JSONPath (`path` starts with `$`):
+                Returns a list of integer replies for every possible path, indicating the length of the array,
+                or None for JSON values matching the path that are not an array.
+                If `path` doen't exist, an empty array will be returned.


Suggested change

If `path` doen't exist, an empty array will be returned.

If `path` doesn't exist, an empty array will be returned.

python/python/glide/async_commands/server_modules/json.py

Yury-Fridlyand

Add a changelog

python/python/glide/async_commands/server_modules/json.py

Yury-Fridlyand · 2024-10-09T20:41:10Z

python/python/tests/tests_server_modules/test_json.py

+        assert await json.arrlen(glide_client, key, "$..a") == [3, 2, None]
+
+        # Legacy path retrieves the first array match at ..a
+        assert await json.arrlen(glide_client, key, "..a") == 3


Test without path arg

Yury-Fridlyand · 2024-10-09T20:41:47Z

python/python/glide/async_commands/server_modules/json.py

+    """
+    Retrieves the length of the array at the specified `path` within the JSON document stored at `key`.
+
+    See https://valkey.io/commands/json.arrlen/ for more details.


Remove the link. We can add valid links later once docs published

Yeah, I will remove them all

shohamazon · 2024-10-09T20:42:46Z

Add a changelog

Thanks, I'm adding it in the end because changelog is edited quite often so there are lots of conflicts

Signed-off-by: Shoham Elias <shohame@amazon.com>

python/python/tests/tests_server_modules/test_json.py

python/python/glide/async_commands/server_modules/json.py

Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Signed-off-by: Chloe <chloe.yip@improving.com>

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com>

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* CI - Minimal and full CI matrix impl Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Fix mypy failing (#2453) --------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Python: adds JSON.ARRLEN command (#2403) --------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> --------- Signed-off-by: avifenesh <aviarchi1994@gmail.com> Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

* CI - Minimal and full CI matrix impl Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Fix mypy failing (valkey-io#2453) --------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Python: adds JSON.ARRLEN command (valkey-io#2403) --------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> --------- Signed-off-by: avifenesh <aviarchi1994@gmail.com> Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

* Update README.md nodejs platform support (#2397) * Update README.md Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com> * Update README.md - lint fix Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com> * Update README.md ling Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com> * Update node/README.md Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com> --------- Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> * CI - Minimal and full CI matrix impl (#2051) * CI - Minimal and full CI matrix impl Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Fix mypy failing (#2453) --------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Python: adds JSON.ARRLEN command (#2403) --------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> --------- Signed-off-by: avifenesh <aviarchi1994@gmail.com> Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> * CI - Minimal and full CI matrix impl (#2051) * CI - Minimal and full CI matrix impl Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Fix mypy failing (#2453) --------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Python: adds JSON.ARRLEN command (#2403) --------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> --------- Signed-off-by: avifenesh <aviarchi1994@gmail.com> Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> * CI - Minimal and full CI matrix impl (#2051) * CI - Minimal and full CI matrix impl Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Fix mypy failing (#2453) --------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Python: adds JSON.ARRLEN command (#2403) --------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> --------- Signed-off-by: avifenesh <aviarchi1994@gmail.com> Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> * Fix for - Minimal and full CI matrix impl #2051 (#2500) * Refactor tests to use async cleanup and improve error handling Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Enhance Jest configuration and add test setup file; update build scripts and dependencies Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Update devDependencies in package.json for hybrid-node-tests to latest versions Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Enhance test utilities and command tests with improved wait logic and version checks Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Refactor tests to assert expected replica reads are less than or equal to actual reads; update connection handling in utilities and allow unused imports in types Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Update dependencies and enhance PyO3 bindings; add new features and improve type handling Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Update GitHub workflows: enhance linting configurations, adjust engine version requirements, and remove obsolete Redis installation workflow Signed-off-by: avifenesh <aviarchi1994@gmail.com> --------- Signed-off-by: avifenesh <aviarchi1994@gmail.com> * fixes for CI (#2552) Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Refactor CI configuration for consistency and clarity Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Refactor CI configuration for consistency and clarity Signed-off-by: avifenesh <aviarchi1994@gmail.com> --------- Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

* CI - Minimal and full CI matrix impl Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Fix mypy failing (#2453) --------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Python: adds JSON.ARRLEN command (#2403) --------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Signed-off-by: avifenesh <aviarchi1994@gmail.com> --------- Signed-off-by: avifenesh <aviarchi1994@gmail.com> Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

shohamazon requested a review from a team as a code owner October 8, 2024 09:31

shohamazon temporarily deployed to AWS_ACTIONS October 8, 2024 09:31 — with GitHub Actions Inactive

shohamazon added the python 🐍 Python wrapper label Oct 8, 2024

shohamazon commented Oct 9, 2024

View reviewed changes

python/python/glide/async_commands/server_modules/json.py Outdated Show resolved Hide resolved

Yury-Fridlyand approved these changes Oct 9, 2024

View reviewed changes

Yury-Fridlyand reviewed Oct 9, 2024

View reviewed changes

shohamazon changed the base branch from main to release-1.2 October 10, 2024 11:16

shohamazon force-pushed the json.arrlen branch from 72db417 to 99b3635 Compare October 10, 2024 11:29

shohamazon had a problem deploying to AWS_ACTIONS October 10, 2024 11:29 — with GitHub Actions Error

shohamazon force-pushed the json.arrlen branch from 99b3635 to eb01dc8 Compare October 10, 2024 11:29

shohamazon had a problem deploying to AWS_ACTIONS October 10, 2024 11:30 — with GitHub Actions Failure

shohamazon had a problem deploying to AWS_ACTIONS October 10, 2024 11:30 — with GitHub Actions Error

Python: adds JSON.ARRLEN command

510247f

Signed-off-by: Shoham Elias <shohame@amazon.com>

shohamazon force-pushed the json.arrlen branch from eb01dc8 to 510247f Compare October 10, 2024 11:58

shohamazon temporarily deployed to AWS_ACTIONS October 10, 2024 11:59 — with GitHub Actions Inactive

shohamazon commented Oct 10, 2024

View reviewed changes

python/python/tests/tests_server_modules/test_json.py Outdated Show resolved Hide resolved

shohamazon commented Oct 10, 2024

View reviewed changes

python/python/tests/tests_server_modules/test_json.py Outdated Show resolved Hide resolved

shohamazon commented Oct 10, 2024

View reviewed changes

python/python/glide/async_commands/server_modules/json.py Outdated Show resolved Hide resolved

Apply suggestions from code review

ab3f567

Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

shohamazon temporarily deployed to AWS_ACTIONS October 10, 2024 12:52 — with GitHub Actions Inactive

shohamazon merged commit fcc6001 into release-1.2 Oct 10, 2024

shohamazon deleted the json.arrlen branch October 10, 2024 13:09

shohamazon mentioned this pull request Oct 10, 2024

Json module for Python #645

Closed

22 tasks

mo-amzn pushed a commit that referenced this pull request Oct 14, 2024

Python: adds JSON.ARRLEN command (#2403)

5702474

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024

Python: adds JSON.ARRLEN command (valkey-io#2403)

0f46a79

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024

Python: adds JSON.ARRLEN command (valkey-io#2403)

d298aeb

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

avifenesh pushed a commit that referenced this pull request Oct 22, 2024

Python: adds JSON.ARRLEN command (#2403)

91d6a22

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

mo-amzn pushed a commit to mo-amzn/valkey-glide that referenced this pull request Oct 22, 2024

Python: adds JSON.ARRLEN command (valkey-io#2403)

8d236e2

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python: adds JSON.ARRLEN command#2403

Python: adds JSON.ARRLEN command#2403
shohamazon merged 2 commits intorelease-1.2from
json.arrlen

shohamazon commented Oct 8, 2024

Uh oh!

shohamazon Oct 9, 2024

Uh oh!

Uh oh!

Yury-Fridlyand left a comment

Uh oh!

Uh oh!

Yury-Fridlyand Oct 9, 2024

Uh oh!

Yury-Fridlyand Oct 9, 2024

Uh oh!

shohamazon Oct 9, 2024

Uh oh!

shohamazon commented Oct 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	If `path` doen't exist, an empty array will be returned.
	If `path` doesn't exist, an empty array will be returned.

Conversation

shohamazon commented Oct 8, 2024

Uh oh!

shohamazon Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Yury-Fridlyand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Yury-Fridlyand Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

Yury-Fridlyand Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

shohamazon Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

shohamazon commented Oct 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants