Skip to content

Node: Add CI support for server modules#2472

Merged
acarbonetto merged 17 commits intorelease-1.2from
node/tjz-modulesci
Oct 18, 2024
Merged

Node: Add CI support for server modules#2472
acarbonetto merged 17 commits intorelease-1.2from
node/tjz-modulesci

Conversation

@tjzhang-BQ
Copy link
Copy Markdown
Contributor

@tjzhang-BQ tjzhang-BQ commented Oct 17, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): [#2431]

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@tjzhang-BQ tjzhang-BQ added the node 🐢 Node.js wrapper label Oct 17, 2024
@tjzhang-BQ tjzhang-BQ marked this pull request as ready for review October 17, 2024 18:44
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner October 17, 2024 18:44
@Yury-Fridlyand
Copy link
Copy Markdown

Yury-Fridlyand commented Oct 17, 2024

Please add changelog and apply my comments from #2427

Yury-Fridlyand
Yury-Fridlyand reviewed Oct 17, 2024
View reviewed changes
@tjzhang-BQ
Node: add server modules CI support
82bbe94 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ
adding changelog, update indent, addressing comments
aa82897 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ
address comments
4cdf0cc 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ
enable cluster mode
9f23326 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ
linting test file
5dfd4ae 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ
testing tls flag
ffa46f7 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ
testing useTLS override
89378b1 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ
update cluster shard count
a76a4cf 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ
test creating cluster directly
4e27882 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ
test creating cluster with --cluster_mode off
b0f9cc6 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
acarbonetto added a commit that referenced this pull request Oct 17, 2024
@acarbonetto
Add node CI changes from #2472
962546a 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@Yury-Fridlyand
try parsing tls flag
e0b361b 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
try to fix CI
3e2126a 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
try to fix CI
fbceed7 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
try to fix CI
80ad0ab 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
update node in ci
6c4fb2a 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
fix parsing tls
af75a94 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
Yury-Fridlyand approved these changes Oct 18, 2024
View reviewed changes
@cyip10
uncommenting AWS ACTIONS & updating test case
21a512a 
Signed-off-by: Chloe <chloe.yip@improving.com>
acarbonetto
acarbonetto approved these changes Oct 18, 2024
View reviewed changes
node/tests/TestUtilities.ts
port,
})),
protocol,
useTLS: parseCommandLineArgs()["tls"] == "true",
Copy link
Copy Markdown
Contributor

@acarbonetto acarbonetto Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok - this will work - not sure why we don't check addresses here too, rather than getting command-line parameters in each test separately.

Will clean this up in a follow-up PR

@acarbonetto acarbonetto merged commit fa12563 into release-1.2 Oct 18, 2024
@acarbonetto acarbonetto deleted the node/tjz-modulesci branch October 18, 2024 15:38
@Yury-Fridlyand Yury-Fridlyand linked an issue Oct 18, 2024 that may be closed by this pull request
Node: add module testing CI #2431
Closed
2 tasks
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024
@tjzhang-BQ @Yury-Fridlyand
@cyip10 @avifenesh
Node: Add CI support for server modules (valkey-io#2472)
cb375b9 
* Node: add server modules CI support

---------

Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Chloe <chloe.yip@improving.com>
Co-authored-by: TJ Zhang <tj.zhang@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Chloe <chloe.yip@improving.com>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Oct 21, 2024
Merged
6 tasks
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024
@tjzhang-BQ @Yury-Fridlyand
@cyip10 @avifenesh
Node: Add CI support for server modules (valkey-io#2472)
1189095 
* Node: add server modules CI support

---------

Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Chloe <chloe.yip@improving.com>
Co-authored-by: TJ Zhang <tj.zhang@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Chloe <chloe.yip@improving.com>
mo-amzn pushed a commit to mo-amzn/valkey-glide that referenced this pull request Oct 22, 2024
@tjzhang-BQ @Yury-Fridlyand
@cyip10 @mo-amzn
Node: Add CI support for server modules (valkey-io#2472)
e98ad97 
* Node: add server modules CI support

---------

Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Chloe <chloe.yip@improving.com>
Co-authored-by: TJ Zhang <tj.zhang@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Chloe <chloe.yip@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

node 🐢 Node.js wrapper

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node: add module testing CI

4 participants

@tjzhang-BQ @Yury-Fridlyand @acarbonetto @cyip10