Core: add az awareness to read strategy by adarovadya · Pull Request #2539 · valkey-io/valkey-glide

adarovadya · 2024-10-29T16:34:14Z

Issue link

This Pull Request is linked to issue (URL): #643

This PR adding support to AZ Affinity strategy for CME and CMD.
Only version Valkey-8.0 and above support AZ affinity strategy, since only from this version the info command supports the availability-zone property, which is required to support this feature.

In addition, as for now we added support only to the Async Client. Support for the Sync Client has been added to our backlog.

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Commits will be squashed upon merging.

glide-core/Cargo.toml

.github/workflows/rust.yml

CHANGELOG.md

glide-core/redis-rs/redis/src/aio/connection.rs

glide-core/redis-rs/redis/src/client.rs

glide-core/redis-rs/redis/src/cluster_slotmap.rs

glide-core/src/client/mod.rs

glide-core/src/client/standalone_client.rs

glide-core/src/client/types.rs

node/src/BaseClient.ts

.github/workflows/redis-rs.yml

glide-core/redis-rs/redis/Cargo.toml

glide-core/redis-rs/redis/src/aio/connection_manager.rs

eifrah-aws · 2024-11-14T17:10:45Z

glide-core/redis-rs/redis/src/aio/mod.rs

+        Ok(value) => {
+            let info_dict: InfoDict = FromRedisValue::from_redis_value(&value)?;
+            if let Some(node_az) = info_dict.get::<String>("availability_zone") {
+                con.set_az(Some(node_az));


I would also add a debug message stating that the property "availability_zone" could not be found for this redis server

@eifrah-aws I dont think its required - not having AZ is ok (redis/older versions)

glide-core/redis-rs/redis/src/aio/mod.rs

glide-core/redis-rs/redis/src/cluster_async/connections_container.rs

glide-core/redis-rs/redis/src/cluster_async/mod.rs

glide-core/src/client/standalone_client.rs

eifrah-aws · 2024-11-14T17:51:05Z

glide-core/src/client/standalone_client.rs

    }

-    fn get_connection(&self, readonly: bool) -> &ReconnectingConnection {
+    async fn round_robin_read_from_replica_az_awareness(


I am worried that if we fix a bug in this method, we will also need to fix the one that is a copy - paste of this one above

what is the bug?

glide-core/src/client/types.rs

Signed-off-by: Adar Ovadia <adarov@amazon.com>

…han 7.1 version Signed-off-by: Adar Ovadia <adarov@amazon.com>

Signed-off-by: Adar Ovadia <adarov@amazon.com>

CHANGELOG.md

glide-core/redis-rs/redis/src/aio/connection.rs

glide-core/redis-rs/redis-test/src/lib.rs

glide-core/redis-rs/redis/src/aio/connection.rs

glide-core/redis-rs/redis/src/client.rs

glide-core/redis-rs/redis/src/cluster_async/mod.rs

glide-core/redis-rs/redis/tests/support/mock_cluster.rs

glide-core/redis-rs/redis/tests/test_cluster_async.rs

Signed-off-by: Adar Ovadia <adarov@amazon.com>

glide-core/redis-rs/redis/tests/test_cluster_async.rs

Signed-off-by: Adar Ovadia <adarov@amazon.com>

adarovadya changed the title ~~redis-core: add az awareness to read strategy~~ redis-core: add az awareness to read strategy- DRAFT Oct 29, 2024

asafpamzn mentioned this pull request Oct 30, 2024

AZ Awareness #643

Closed

adarovadya force-pushed the az-awerness-1.2 branch 3 times, most recently from ec034fe to 9d5e64d Compare November 7, 2024 16:00

adarovadya changed the title ~~redis-core: add az awareness to read strategy- DRAFT~~ redis-core: add az awareness to read strategy Nov 7, 2024

adarovadya changed the title ~~redis-core: add az awareness to read strategy~~ Core: add az awareness to read strategy Nov 7, 2024

adarovadya force-pushed the az-awerness-1.2 branch 5 times, most recently from 518c991 to 5edc891 Compare November 7, 2024 17:32

adarovadya marked this pull request as ready for review November 7, 2024 17:38

adarovadya requested a review from a team as a code owner November 7, 2024 17:38

Yury-Fridlyand added the Rust core label Nov 7, 2024

Yury-Fridlyand reviewed Nov 7, 2024

View reviewed changes

glide-core/Cargo.toml Outdated Show resolved Hide resolved

Yury-Fridlyand reviewed Nov 7, 2024

View reviewed changes

.github/workflows/rust.yml Outdated Show resolved Hide resolved

Yury-Fridlyand requested a review from jonathanl-bq November 7, 2024 20:54

eifrah-aws requested changes Nov 7, 2024

View reviewed changes

adarovadya force-pushed the az-awerness-1.2 branch 11 times, most recently from 0b3de2c to 47691cf Compare November 12, 2024 08:57

avifenesh reviewed Nov 14, 2024

View reviewed changes

.github/workflows/redis-rs.yml Outdated Show resolved Hide resolved

avifenesh reviewed Nov 14, 2024

View reviewed changes

.github/workflows/redis-rs.yml Outdated Show resolved Hide resolved

adarovadya force-pushed the az-awerness-1.2 branch 2 times, most recently from 8f419bc to a72f324 Compare November 14, 2024 11:29

eifrah-aws self-requested a review November 14, 2024 11:59

adarovadya force-pushed the az-awerness-1.2 branch from a72f324 to c3e444e Compare November 14, 2024 12:43

eifrah-aws requested changes Nov 14, 2024

View reviewed changes

Adar Ovadia added 6 commits November 16, 2024 20:05

redis-core: add az awareness to read strategy

efe8c52

Signed-off-by: Adar Ovadia <adarov@amazon.com>

redis-core: add az awareness to read strategy

47e6bdc

Signed-off-by: Adar Ovadia <adarov@amazon.com>

redis-core: add az awareness to read strategy

9167493

Signed-off-by: Adar Ovadia <adarov@amazon.com>

redis-core: add az awareness to read strategy

47e883e

Signed-off-by: Adar Ovadia <adarov@amazon.com>

add feature to run the AZ Affinity strategy only for valkey greater t…

a03f607

…han 7.1 version Signed-off-by: Adar Ovadia <adarov@amazon.com>

Core: az affinity strategy

c9556e0

Signed-off-by: Adar Ovadia <adarov@amazon.com>

adarovadya force-pushed the az-awerness-1.2 branch from c3e444e to 3b34488 Compare November 16, 2024 21:58

standalone az awareness

2ab55f2

Signed-off-by: Adar Ovadia <adarov@amazon.com>

adarovadya force-pushed the az-awerness-1.2 branch from 3b34488 to 2ab55f2 Compare November 16, 2024 22:05

ikolomi requested changes Nov 17, 2024

View reviewed changes

Adar Ovadia added 2 commits November 17, 2024 11:59

remove unessecrry get and set and fix tests

7702069

Signed-off-by: Adar Ovadia <adarov@amazon.com>

remove unessecrry az return type

938a1ee

Signed-off-by: Adar Ovadia <adarov@amazon.com>

eifrah-aws reviewed Nov 18, 2024

View reviewed changes

glide-core/redis-rs/redis/tests/test_cluster_async.rs Outdated Show resolved Hide resolved

glide-core/redis-rs/redis/tests/test_cluster_async.rs Outdated Show resolved Hide resolved

add version check with mutex to skip tests in runtime

6d2e297

Signed-off-by: Adar Ovadia <adarov@amazon.com>

adarovadya force-pushed the az-awerness-1.2 branch from e27985b to 6d2e297 Compare November 18, 2024 08:46

eifrah-aws self-requested a review November 18, 2024 08:48

eifrah-aws approved these changes Nov 18, 2024

View reviewed changes

ikolomi approved these changes Nov 18, 2024

View reviewed changes

adarovadya merged commit ddd98cc into valkey-io:release-1.2 Nov 18, 2024

adarovadya deleted the az-awerness-1.2 branch January 15, 2025 11:50

yipin-chen mentioned this pull request Feb 25, 2025

[Task] Go: Support AZ Awareness #3267

Closed

Conversation

adarovadya commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue link

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eifrah-aws Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

ikolomi Nov 17, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eifrah-aws Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

adarovadya Nov 16, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adarovadya commented Oct 29, 2024 •

edited

Loading