Skip to content
Merged
Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
fea19d1
`FT.AGGREAGATE`.
Yury-Fridlyand Oct 31, 2024
735501d
minor fixes
Yury-Fridlyand Oct 31, 2024
b3b5f09
Address PR review.
Yury-Fridlyand Oct 31, 2024
8298fc9
Address PR review.
Yury-Fridlyand Nov 1, 2024
60725f8
Node: Add FT.PROFILE command
acarbonetto Nov 6, 2024
36954c9
Fix FT.PROFILE tests
acarbonetto Nov 6, 2024
603d7f5
Fix FT.PROFILE tests
acarbonetto Nov 6, 2024
cc2fa4d
Fix FT.PROFILE tests
acarbonetto Nov 6, 2024
e742943
Fix FT.PROFILE tests
acarbonetto Nov 6, 2024
2388b30
Update search | aggregate options condition
acarbonetto Nov 6, 2024
b35d5ac
Update FtAggregateOptinon params
acarbonetto Nov 6, 2024
af2e803
Split ft.profile
acarbonetto Nov 6, 2024
cc60473
Update ft.profile test
acarbonetto Nov 6, 2024
ea942c3
Update ft.profile test
acarbonetto Nov 6, 2024
96be360
Add javadoc for ft.profile
acarbonetto Nov 6, 2024
d87ccc3
Add changelog; add imports
acarbonetto Nov 6, 2024
4f0e37f
Clean up FT.PROFILE from review
acarbonetto Nov 7, 2024
8de1c86
Fix merge conflicts
acarbonetto Nov 8, 2024
0e0d5f6
Fix return type for ft.profile
acarbonetto Nov 8, 2024
6677f68
Fix return type for ft.profile
acarbonetto Nov 8, 2024
af6419a
Fix return type for ft.profile
acarbonetto Nov 8, 2024
5df3f02
Add profile tests
acarbonetto Nov 8, 2024
a8dc490
FT.PROFILE - convert using simple string
acarbonetto Nov 8, 2024
96f076c
Fix return type for FT.PROFILE
acarbonetto Nov 8, 2024
d384135
Fix return type for FT.PROFILE
acarbonetto Nov 8, 2024
009ecec
Fix return type for FT.PROFILE
acarbonetto Nov 8, 2024
b9b1493
Remove debug
acarbonetto Nov 8, 2024
886faf9
Fix review comments
acarbonetto Nov 12, 2024
b2f48a5
Fix test
acarbonetto Nov 12, 2024
85add91
Remove duplicate interfaces
acarbonetto Nov 12, 2024
7088401
Re-add merge conflicted test
acarbonetto Nov 12, 2024
92d1387
Update tests
acarbonetto Nov 12, 2024
a814baf
prettier
acarbonetto Nov 12, 2024
599a828
better tests
acarbonetto Nov 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
* Node: Added `FT.CREATE` ([#2501](https://github.com/valkey-io/valkey-glide/pull/2501))
* Node: Added `FT.INFO` ([#2540](https://github.com/valkey-io/valkey-glide/pull/2540))
* Node: Added `FT.AGGREGATE` ([#2554](https://github.com/valkey-io/valkey-glide/pull/2554))
* Node: Added `FT.PROFILE` ([#2633](https://github.com/valkey-io/valkey-glide/pull/2633))
* Java: Added `JSON.DEBUG` ([#2520](https://github.com/valkey-io/valkey-glide/pull/2520))
* Java: Added `JSON.ARRINSERT` and `JSON.ARRLEN` ([#2476](https://github.com/valkey-io/valkey-glide/pull/2476))
* Java: Added `JSON.ARRINDEX` ([#2546](https://github.com/valkey-io/valkey-glide/pull/2546))
Expand Down
4 changes: 2 additions & 2 deletions glide-core/src/client/value_conversion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1132,8 +1132,8 @@ pub(crate) fn convert_to_expected_type(
let res = vec![
convert_to_expected_type(array.remove(0), *type_of_query)?,
convert_to_expected_type(array.remove(0), Some(ExpectedReturnType::Map {
key_type: &None,
value_type: &None,
key_type: &Some(ExpectedReturnType::SimpleString),
value_type: &Some(ExpectedReturnType::Double),
}))?];

Ok(Value::Array(res))
Expand Down
4 changes: 4 additions & 0 deletions node/npm/glide/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,9 @@ function initialize() {
FtAggregateSortBy,
FtAggregateSortProperty,
FtAggregateApply,
FtAggregateReturnType,
FtSearchReturnType,
FtProfileOtions,
GlideRecord,
GlideString,
JsonGetOptions,
Expand Down Expand Up @@ -268,7 +270,9 @@ function initialize() {
FtAggregateSortBy,
FtAggregateSortProperty,
FtAggregateApply,
FtAggregateReturnType,
FtSearchReturnType,
FtProfileOtions,
GlideRecord,
GlideJson,
GlideString,
Expand Down
Loading