Java: Shadow netty dependencies. - breaking change#3004
Java: Shadow netty dependencies. - breaking change#3004Yury-Fridlyand merged 18 commits intomainfrom
netty dependencies. - breaking change#3004Conversation
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
|
TODO: review netty/netty#6665 to confirm that we don't need more changes |
|
It seems we need to rename the .so files that get bundled in META-INF/native to have the same prefix was the shaded artifacts per: netty/netty#6665 |
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
netty dependencies.netty dependencies. - breaking change
…adow-netty Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
netty dependencies. - breaking changenetty dependencies. - breaking change
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
java/client/src/main/java/glide/connectors/resources/ThreadPoolResource.java
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
jamesx-improving
left a comment
There was a problem hiding this comment.
All comments nit, LGTM.
|
Thanks for this PR Do you have any plans to release this update? We recently discovered this required after upgrading to Spring Boot 3.4.4 ( Netty version incompatibility between SB 3.4.4 and Glide 1.3.0 ). We're currently waiting for this update before we can proceed ? |
|
Hi @cena7 |
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Shadow `netty` dependencies. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
#3367
TODO:
This PR also includes validation of exported symbols (via
modules-info.javain IT). Corresponding fixes were made to pass the check.Following #2931, shadowing netty deps
List of packages being shadowed:
This fix is breaking, because feature of customizing the netty thread pool was removed. All classes/files and corresponding tests were removed.
Package files:
valkey-glide-255.255.255.module.json
valkey-glide-255.255.255.pom.txt
valkey-glide-255.255.255-linux-x86_64.jar.zip
Jar content
Issue link
This Pull Request is linked to issue (URL): fixes #3402
Checklist
Before submitting the PR make sure the following are checked: