-
Notifications
You must be signed in to change notification settings - Fork 149
Go: Implement PfMerge command #3082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
niharikabhavaraju
merged 20 commits into
valkey-io:main
from
niharikabhavaraju:niharika-hyperlogcmd
Apr 1, 2025
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d71f7ad
Implemented pfmerge command
niharikabhavaraju 18a2f4a
Merge branch 'main' into niharika-hyperlogcmd
Yury-Fridlyand 2d5a3db
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju 4db7749
Fixed review comment
niharikabhavaraju 6c83dc6
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju ca2a2f9
Fixed code review comments
niharikabhavaraju f23e061
Fixed failing example
niharikabhavaraju 99f67a7
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju 4f21c7c
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju 43d831c
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju f62cdf0
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju 94ab7f7
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju d4d5636
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju dde41b8
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju 9e92990
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju 526bf2f
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju 590204f
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju 670e2e2
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju de44c3f
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju 3596ec7
Merge branch 'main' into niharika-hyperlogcmd
niharikabhavaraju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check if at-least one sourceKey is as
PFMergerequire at least one source key and this would lead to anyhow failure and will waste one network call, we can use something like this :-There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need, we don't do this in other commands/clients
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But adding this check will make the execution of command more efficient isn't it, and if other clients have not implemented such behavior, it seems a miss because anyhow the execution of command is going to fail.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omangesg , I checked in valkey cli , the PFMERGE command with only a destination key and no source keys, will return "OK" as the response.

The command doesn't fail or produce an error, it creates the destination key as an empty HyperLogLog if it doesn't exist yet and returns "OK"