Go: Implement LastSave command#3086
Merged
niharikabhavaraju merged 33 commits intovalkey-io:mainfrom Mar 27, 2025
Merged
Conversation
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
omangesg
reviewed
Feb 7, 2025
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Yury-Fridlyand
left a comment
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
What about lastsave for standalone client?
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Yury-Fridlyand
suggested changes
Feb 15, 2025
There was a problem hiding this comment.
- Need to move examples to the corresponding file(s).
- Need to add a changelog entry as of now.
RouteOptionwas reworked in 1.3 branch.
Please wait for backporting all changes from release-1.3 branch. You can merge/rebase you branch after that and implement required fixes.
UPD backported in #3202
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
|
Please add changelog and fix PR description (needs a link to an issue) |
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Yury-Fridlyand
left a comment
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
Please add a changelog entry and update PR description by adding a correct issue link.
Fix CI failures.
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
4 tasks
Yury-Fridlyand
approved these changes
Mar 20, 2025
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
Signed-off-by: EdricCua <ecuartero@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #3399
Checklist
Before submitting the PR make sure the following are checked: