Core/FFI/Go: Add Support for Async and Sync Client Types in FFI#3451
Merged
barshaul merged 2 commits intovalkey-io:mainfrom Mar 31, 2025
Merged
Core/FFI/Go: Add Support for Async and Sync Client Types in FFI#3451barshaul merged 2 commits intovalkey-io:mainfrom
barshaul merged 2 commits intovalkey-io:mainfrom
Conversation
bc4c45c to
e5fc4d1
Compare
eedd057 to
badc167
Compare
|
Keep in mind that go client is completely sync (even though it uses async backend from glide core). |
Member
Can you explain the meaning in this context? Do you mean that there's no callbacks? |
|
This change is no-op for go client. It is sync already. |
eifrah-aws
reviewed
Mar 30, 2025
Signed-off-by: barshaul <barshaul@amazon.com>
Signed-off-by: barshaul <barshaul@amazon.com>
eifrah-aws
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Summary
This PR introduces support for both asynchronous and synchronous clients across the Rust-C FFI boundary. It unifies command execution and error handling while allowing consuming languages to choose the interaction model that fits their needs. This PR establishes the groundwork required to support synchronous APIs in the Python wrapper.
✅ Key Changes
🔹 Rust (FFI Layer)
🔹 Go
🔹 Tests
🧠 Motivation
Issue link
This Pull Request is linked to issue (URL): #3457
Checklist
Before submitting the PR make sure the following are checked: