Merged
Conversation
jbrinkman
force-pushed
the
go/jbrinkman-pubsub-channels-command
branch
from
a2121cb to
dd33b7d
Compare
…e PubSubMessageQueue with signal channel support; refactor integration tests to utilize new client creation methods and improve message handling. Signed-off-by: jbrinkman <joe.brinkman@improving.com>
…erns into a single comprehensive test function, improving maintainability and readability. This change introduces a parameterized approach to test various client types and message reading methods. Signed-off-by: jbrinkman <joe.brinkman@improving.com>
…e verification logic and introducing parameterized tests for various client types and message reading methods. This update improves test maintainability and readability while ensuring comprehensive coverage of PubSub functionality. Signed-off-by: jbrinkman <joe.brinkman@improving.com>
…t for enhanced channel management. Update PubSubCommands interface to include new methods. Introduce example utility functions for standalone and cluster clients with subscription capabilities, ensuring a clean state before tests. Signed-off-by: jbrinkman <joe.brinkman@improving.com>
…client function. Update Go module dependencies to include new libraries for improved functionality. Refactor baseClient methods for PubSubChannels and PubSubChannelsWithPattern, ensuring proper error handling and client closure in tests. Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
jbrinkman
force-pushed
the
go/jbrinkman-pubsub-channels-command
branch
from
dd33b7d to
41bf80f
Compare
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
yipin-chen
reviewed
Apr 24, 2025
yipin-chen
reviewed
Apr 24, 2025
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
yipin-chen
approved these changes
Apr 25, 2025
Yury-Fridlyand
approved these changes
Apr 25, 2025
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Joseph Brinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
jbrinkman
force-pushed
the
go/jbrinkman-pubsub-channels-command
branch
from
76e15b6 to
0ed6be4
Compare
jbrinkman
force-pushed
the
go/jbrinkman-pubsub-channels-command
branch
from
0ed6be4 to
fc8a6f5
Compare
jbrinkman
force-pushed
the
go/jbrinkman-pubsub-channels-command
branch
from
fc8a6f5 to
0ed6be4
Compare
prateek-kumar-improving
approved these changes
Apr 25, 2025
ikolomi
pushed a commit
that referenced
this pull request
May 11, 2025
* Add PubSubHandler interface and GetQueue method to BaseClient; enhance PubSubMessageQueue with signal channel support; refactor integration tests to utilize new client creation methods and improve message handling. Signed-off-by: jbrinkman <joe.brinkman@improving.com> * Refactor PubSub integration tests to consolidate message receipt patterns into a single comprehensive test function, improving maintainability and readability. This change introduces a parameterized approach to test various client types and message reading methods. Signed-off-by: jbrinkman <joe.brinkman@improving.com> * Refactor and enhance PubSub integration tests by consolidating message verification logic and introducing parameterized tests for various client types and message reading methods. This update improves test maintainability and readability while ensuring comprehensive coverage of PubSub functionality. Signed-off-by: jbrinkman <joe.brinkman@improving.com> * Add PubSubChannels and PubSubChannelsWithPattern methods to baseClient for enhanced channel management. Update PubSubCommands interface to include new methods. Introduce example utility functions for standalone and cluster clients with subscription capabilities, ensuring a clean state before tests. Signed-off-by: jbrinkman <joe.brinkman@improving.com> * Enhance client management by adding strong reference checks in close_client function. Update Go module dependencies to include new libraries for improved functionality. Refactor baseClient methods for PubSubChannels and PubSubChannelsWithPattern, ensuring proper error handling and client closure in tests. Signed-off-by: jbrinkman <joe.brinkman@improving.com> * add pubsub integration test for PubSub channels Signed-off-by: jbrinkman <joe.brinkman@improving.com> * fix formatting Signed-off-by: jbrinkman <joe.brinkman@improving.com> * Update changelog Signed-off-by: jbrinkman <joe.brinkman@improving.com> * code review feedback updates Signed-off-by: jbrinkman <joe.brinkman@improving.com> * Update go/api/base_client.go Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Joseph Brinkman <joe.brinkman@improving.com> * remove unneeded logic Signed-off-by: jbrinkman <joe.brinkman@improving.com> --------- Signed-off-by: jbrinkman <joe.brinkman@improving.com> Signed-off-by: Joseph Brinkman <joe.brinkman@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue link
This Pull Request is linked to issue (#3664)
Checklist
Before submitting the PR make sure the following are checked: