Go: PubSub Publish Sharded#3692

Merged

jbrinkman merged 19 commits intomainfrom

go/jbrinkman-pubsub-publishshard

Apr 28, 2025

Collaborator

jbrinkman commented Apr 28, 2025 •

edited

Loading

Description

Add Sharded support for Publish command on GlideClusterClient
Add documentation example
Add Table driven Integration tests
Update Changelog

Issue link

This Pull Request is linked to issue (#3664)

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Create merge commit if merging release branch into main, squash otherwise.

jbrinkman requested a review from a team as a code owner

April 28, 2025 16:53

jbrinkman had a problem deploying to AWS_ACTIONS

April 28, 2025 16:53

— with

GitHub Actions Error

jbrinkman mentioned this pull request

GO: PubSub Commands #3664

Closed

7 tasks

Yury-Fridlyand added the go 🏃 label

Yury-Fridlyand approved these changes

View reviewed changes

jbrinkman had a problem deploying to AWS_ACTIONS

April 28, 2025 20:18

— with

GitHub Actions Error

jbrinkman added 19 commits

April 28, 2025 16:47


          Add PubSubHandler interface and GetQueue method to BaseClient; enhanc…

fe84f00

…e PubSubMessageQueue with signal channel support; refactor integration tests to utilize new client creation methods and improve message handling.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          Refactor PubSub integration tests to consolidate message receipt patt…

2f86051

…erns into a single comprehensive test function, improving maintainability and readability. This change introduces a parameterized approach to test various client types and message reading methods.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          Refactor and enhance PubSub integration tests by consolidating messag…

3b8d224

…e verification logic and introducing parameterized tests for various client types and message reading methods. This update improves test maintainability and readability while ensuring comprehensive coverage of PubSub functionality.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          Add PubSubChannels and PubSubChannelsWithPattern methods to baseClien…

d6caa36

…t for enhanced channel management. Update PubSubCommands interface to include new methods. Introduce example utility functions for standalone and cluster clients with subscription capabilities, ensuring a clean state before tests.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          Enhance client management by adding strong reference checks in close_…

569f940

…client function. Update Go module dependencies to include new libraries for improved functionality. Refactor baseClient methods for PubSubChannels and PubSubChannelsWithPattern, ensuring proper error handling and client closure in tests.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          fix formatting

b107f62

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          Add PubSubNumPat method to baseClient for counting unique subscribed …

f582a58

…patterns. Update PubSubCommands interface and implement integration tests for standalone and cluster clients. Add example usage for documentation.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          Add PubSub NumSub

ee1480e

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          Refactor PubSubNumSub method in baseClient to simplify response handl…

1bacd31

…ing and improve readability. Update related tests for clarity and consistency in naming conventions. Add new integration tests for PubSubNumSub functionality across standalone and cluster clients.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          fix merge errors

5ff1dc6

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          docs: added detailed parameter and return value descriptions to impro…

438bec0

…ve clarity and usability for developers.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          Add PubSubChannels and PubSubChannelsWithPattern methods to baseClien…

b1e4312

…t for enhanced channel management. Update PubSubCommands interface to include new methods. Introduce example utility functions for standalone and cluster clients with subscription capabilities, ensuring a clean state before tests.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          fix formatting

8d9ff03

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          Add PubSubNumPat method to baseClient for counting unique subscribed …

fe645ea

…patterns. Update PubSubCommands interface and implement integration tests for standalone and cluster clients. Add example usage for documentation.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          sharded publish

0cc64e6

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          implement sharded mode support in pubsub tests for subscriptions and …

fbacab6

…publishing

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          update publish command docs

6d3128a

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          refactor: update skipIfServerVersionLowerThanBy to work with subtests

26cae60

Signed-off-by: jbrinkman <joe.brinkman@improving.com>


          fix linting error

f6d02a2

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

jbrinkman force-pushed the go/jbrinkman-pubsub-publishshard branch from 3787515 to f6d02a2 Compare

April 28, 2025 20:57

jbrinkman had a problem deploying to AWS_ACTIONS

April 28, 2025 20:57

— with

GitHub Actions Error

jbrinkman had a problem deploying to AWS_ACTIONS

April 28, 2025 22:24

— with

GitHub Actions Error

yipin-chen approved these changes

View reviewed changes

jbrinkman force-pushed the go/jbrinkman-pubsub-publishshard branch from 9c910b7 to f6d02a2 Compare

April 28, 2025 22:33

jbrinkman had a problem deploying to AWS_ACTIONS

April 28, 2025 22:33

— with

GitHub Actions Failure

jbrinkman merged commit 26343b1 into main

28 of 30 checks passed

shohamazon pushed a commit to shohamazon/glide-for-redis that referenced this pull request


          Go: PubSub Publish Sharded (valkey-io#3692)

e8b8180

* Add PubSubHandler interface and GetQueue method to BaseClient; enhance PubSubMessageQueue with signal channel support; refactor integration tests to utilize new client creation methods and improve message handling.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Refactor PubSub integration tests to consolidate message receipt patterns into a single comprehensive test function, improving maintainability and readability. This change introduces a parameterized approach to test various client types and message reading methods.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Refactor and enhance PubSub integration tests by consolidating message verification logic and introducing parameterized tests for various client types and message reading methods. This update improves test maintainability and readability while ensuring comprehensive coverage of PubSub functionality.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Add PubSubChannels and PubSubChannelsWithPattern methods to baseClient for enhanced channel management. Update PubSubCommands interface to include new methods. Introduce example utility functions for standalone and cluster clients with subscription capabilities, ensuring a clean state before tests.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Enhance client management by adding strong reference checks in close_client function. Update Go module dependencies to include new libraries for improved functionality. Refactor baseClient methods for PubSubChannels and PubSubChannelsWithPattern, ensuring proper error handling and client closure in tests.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* fix formatting

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Add PubSubNumPat method to baseClient for counting unique subscribed patterns. Update PubSubCommands interface and implement integration tests for standalone and cluster clients. Add example usage for documentation.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Add PubSub NumSub

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Refactor PubSubNumSub method in baseClient to simplify response handling and improve readability. Update related tests for clarity and consistency in naming conventions. Add new integration tests for PubSubNumSub functionality across standalone and cluster clients.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* fix merge errors

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* docs: added detailed parameter and return value descriptions to improve clarity and usability for developers.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Add PubSubChannels and PubSubChannelsWithPattern methods to baseClient for enhanced channel management. Update PubSubCommands interface to include new methods. Introduce example utility functions for standalone and cluster clients with subscription capabilities, ensuring a clean state before tests.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* fix formatting

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Add PubSubNumPat method to baseClient for counting unique subscribed patterns. Update PubSubCommands interface and implement integration tests for standalone and cluster clients. Add example usage for documentation.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* sharded publish

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* implement sharded mode support in pubsub tests for subscriptions and publishing

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* update publish command docs

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* refactor: update skipIfServerVersionLowerThanBy to work with subtests

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* fix linting error

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

---------

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

ikolomi pushed a commit that referenced this pull request


          Go: PubSub Publish Sharded (#3692)

5c2ebea

* Add PubSubHandler interface and GetQueue method to BaseClient; enhance PubSubMessageQueue with signal channel support; refactor integration tests to utilize new client creation methods and improve message handling.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Refactor PubSub integration tests to consolidate message receipt patterns into a single comprehensive test function, improving maintainability and readability. This change introduces a parameterized approach to test various client types and message reading methods.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Refactor and enhance PubSub integration tests by consolidating message verification logic and introducing parameterized tests for various client types and message reading methods. This update improves test maintainability and readability while ensuring comprehensive coverage of PubSub functionality.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Add PubSubChannels and PubSubChannelsWithPattern methods to baseClient for enhanced channel management. Update PubSubCommands interface to include new methods. Introduce example utility functions for standalone and cluster clients with subscription capabilities, ensuring a clean state before tests.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Enhance client management by adding strong reference checks in close_client function. Update Go module dependencies to include new libraries for improved functionality. Refactor baseClient methods for PubSubChannels and PubSubChannelsWithPattern, ensuring proper error handling and client closure in tests.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* fix formatting

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Add PubSubNumPat method to baseClient for counting unique subscribed patterns. Update PubSubCommands interface and implement integration tests for standalone and cluster clients. Add example usage for documentation.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Add PubSub NumSub

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Refactor PubSubNumSub method in baseClient to simplify response handling and improve readability. Update related tests for clarity and consistency in naming conventions. Add new integration tests for PubSubNumSub functionality across standalone and cluster clients.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* fix merge errors

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* docs: added detailed parameter and return value descriptions to improve clarity and usability for developers.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Add PubSubChannels and PubSubChannelsWithPattern methods to baseClient for enhanced channel management. Update PubSubCommands interface to include new methods. Introduce example utility functions for standalone and cluster clients with subscription capabilities, ensuring a clean state before tests.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* fix formatting

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Add PubSubNumPat method to baseClient for counting unique subscribed patterns. Update PubSubCommands interface and implement integration tests for standalone and cluster clients. Add example usage for documentation.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* sharded publish

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* implement sharded mode support in pubsub tests for subscriptions and publishing

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* update publish command docs

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* refactor: update skipIfServerVersionLowerThanBy to work with subtests

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* fix linting error

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

---------

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

jbrinkman deleted the go/jbrinkman-pubsub-publishshard branch

June 13, 2025 13:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go 🏃