Conversation
7724931 to
1f05675
Compare
1f05675 to
17bfe24
Compare
Yury-Fridlyand
approved these changes
Jul 23, 2025
jamesx-improving
approved these changes
Jul 24, 2025
Collaborator
jamesx-improving
left a comment
There was a problem hiding this comment.
LGTM. All comments nit.
6eb0f09 to
92584d5
Compare
Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
92584d5 to
cef5987
Compare
alexr-bq
pushed a commit
that referenced
this pull request
Sep 3, 2025
* GO: Lazy connect implementation Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com> --------- Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com> Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements lazy connection functionality for the Valkey GLIDE Go client, allowing clients to defer connection establishment until the first operation is executed.
Key Features
Testing
Changes Made
Configuration Updates (
go/config/config.go)lazyConnectfield tobaseClientConfigurationstructWithLazyConnect()method for bothClientConfigurationandClusterClientConfigurationUnit Test (
go/config/config_test.go)TestConfig_LazyConnect()test function covering:Integration Testing Infrastructure
New cluster management utilities
python/tests/utils/cluster.py) to (go/integTest/cluster.go`):ValkeyClusterstruct for managing test cluster instancesConnection testing (
go/integTest/connection_test.go):TestLazyConnectionEstablishesOnFirstCommand()- test validating lazy connection behaviorTest suite enhancements (
go/integTest/glide_test_suite_test.go):createClient()helper function for flexible client creationIssue link
This Pull Request is linked to issue (URL): #4350
Checklist
Before submitting the PR make sure the following are checked: