Skip to content

Core: Fix UDS infinite loop#4612

Merged
jamesx-improving merged 4 commits intomainfrom
core/jamesx-fix-uds-inf-loop
Aug 22, 2025
Merged

Core: Fix UDS infinite loop#4612
jamesx-improving merged 4 commits intomainfrom
core/jamesx-fix-uds-inf-loop

Conversation

@jamesx-improving
Copy link
Copy Markdown
Collaborator

@jamesx-improving jamesx-improving commented Aug 16, 2025

Issue link

This Pull Request is linked to issue (URL): #4591

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@avifenesh
Copy link
Copy Markdown
Member

LGTM please run full matrix on this branch

Copy link
Copy Markdown

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for this?

@jamesx-improving
Copy link
Copy Markdown
Collaborator Author

LGTM please run full matrix on this branch

Full Matrix Test initiated on this branch
https://github.com/valkey-io/valkey-glide/actions/runs/17048156054

Copy link
Copy Markdown
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CHANGELOG

Signed-off-by: James Xin <james.xin@improving.com>
Signed-off-by: James Xin <james.xin@improving.com>
@jamesx-improving
Copy link
Copy Markdown
Collaborator Author

LGTM please run full matrix on this branch

Full Matrix Test initiated on this branch https://github.com/valkey-io/valkey-glide/actions/runs/17048156054

All failures in the Full Matrix Test on this branch is either well-known flaky tests, or network errors.

@jamesx-improving jamesx-improving merged commit a4d38b1 into main Aug 22, 2025
61 of 65 checks passed
@jamesx-improving jamesx-improving deleted the core/jamesx-fix-uds-inf-loop branch August 22, 2025 01:50
alexr-bq pushed a commit that referenced this pull request Sep 3, 2025
* Core: Fix UDS infinite loop

Signed-off-by: James Xin <james.xin@improving.com>

* CHANGELOG

Signed-off-by: James Xin <james.xin@improving.com>

---------

Signed-off-by: James Xin <james.xin@improving.com>
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
xShinnRyuu pushed a commit that referenced this pull request Sep 24, 2025
* Core: Fix UDS infinite loop

Signed-off-by: James Xin <james.xin@improving.com>

* CHANGELOG

Signed-off-by: James Xin <james.xin@improving.com>

---------

Signed-off-by: James Xin <james.xin@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants