Node: Move SELECT command from GlideClient to BaseClient#4849
Merged
affonsov merged 5 commits intorelease-2.1from Oct 7, 2025
Merged
Node: Move SELECT command from GlideClient to BaseClient#4849affonsov merged 5 commits intorelease-2.1from
affonsov merged 5 commits intorelease-2.1from
Conversation
Moves the `select()` method from GlideClient to BaseClient to make it available for both standalone and cluster clients. Updates tests to use the new method instead of customCommand for SELECT operations. - Move select() method from GlideClient to BaseClient - Move createSelect import to BaseClient - Update GlideClusterClient tests to use select() method - Remove outdated warning about reconnection behavior - Simplify documentation to focus on command behavior Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
yipin-chen
approved these changes
Oct 2, 2025
Collaborator
|
Changelog and CI errors |
Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
…ter-mode Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
…ter-mode Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the
SELECTcommand fromGlideClienttoBaseClient, making it available for both standalone and cluster clients.Changes
Core Changes
select()method fromGlideClienttoBaseClientcreateSelectimport toBaseClient.tsfromGlideClient.tsGlideClientandGlideClusterClientDocumentation Updates
select()methodTest Updates
GlideClusterClienttests to use the newselect()method instead ofcustomCommand(["SELECT", "..."])select testfor both RESP2 and RESP3 protocolscopy with DB testto useselect()methodIssue link
This Pull Request is linked to issue (URL): [#4810 ]
Checklist
Before submitting the PR make sure the following are checked: