add AZ_AFFINITY_REPLICAS_AND_PRIMARY read strategy example and diagram #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muhammad Awawdi <[email protected]>
|
@stockholmux @madolson |
|
add yourself to the authors as well |
adarovadya
reviewed
Apr 27, 2025
adarovadya
reviewed
Apr 27, 2025
| In this case, the client attempts to read from a replica in the same AZ. Since none are available in az-2, it falls back to a replica in another AZ, such as az-1 or az-3. | ||
| and the average latency is, for example, about 800 microseconds. | ||
|
|
||
|  |
There was a problem hiding this comment.
I think it's confusing that in the first example the "super" client is the AZ_AFFINITY user, but later the "super" client becomes the AZ_AFFINITY_REPLICAS_AND_PRIMARY user.
I suggest having one example that clearly shows all three cases, and explaining when a user should prefer AZ_AFFINITY over AZ_AFFINITY_REPLICAS_AND_PRIMARY, and vice versa.
There was a problem hiding this comment.
I see this a bit differently. The new example visually clarifies the differences between AZ_AFFINITY and AZ_AFFINITY_REPLICAS_AND_PRIMARY, illustrating real-world scenarios where each one fits best. I'd prefer to retain both examples.
Signed-off-by: Muhammad Awawdi <[email protected]>
stockholmux
requested changes
May 6, 2025
Signed-off-by: Muhammad Awawdi <[email protected]>
adarovadya
approved these changes
May 22, 2025
zarkash-aws
pushed a commit
to zarkash-aws/valkey-io.github.io
that referenced
this pull request
Jun 12, 2025
valkey-io#236) ### Description Adding documentation for the new read strategy AzAffinityReplicasAndPrimary relates to issues valkey-io/valkey-glide#2792 and valkey-io/valkey-glide#3085 <!-- Describe what this change achieves--> ### Issues Resolved <!-- List any issues this PR will resolve. --> <!-- Example: closes #1234 --> ### Check List - [x] Commits are signed per the DCO using `--signoff` By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License. --------- Signed-off-by: Muhammad Awawdi <[email protected]> Signed-off-by: Shai Zarka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding documentation for the new read strategy AzAffinityReplicasAndPrimary
relates to issues valkey-io/valkey-glide#2792 and valkey-io/valkey-glide#3085
Issues Resolved
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.