Bug fix: allow local builds without requiring client directory #243
Conversation
Signed-off-by: Lior Sventitzky <[email protected]>
There was a problem hiding this comment.
So, I can't get this to work as written.
If I change the value of clients_built to false then it does indeed not need the clients to build successfully (yay!) but if then try to run ./build/init-topics-and-clients.sh ../valkey-doc/topics ../valkey-doc/clients I get sed: 1: "content/clients/_index.md": command c expects \ followed by text and it doesn't flip the front matter boolean.
content/clients/_index.md
Outdated
| @@ -2,6 +2,7 @@ | |||
| title = "Client Libraries" | |||
| template = "client-list.html" | |||
| [extra] | |||
| clients_built = true | |||
There was a problem hiding this comment.
Shouldn't this be set to false initially?
There was a problem hiding this comment.
Yep, sorry about that — must’ve been left over from an earlier iteration when I was testing it
Signed-off-by: Lior Sventitzky <[email protected]>
|
@stockholmux did you run it on macOS? I’ve updated the |
Description
Currently building the zola site locally is not possible when the clients directory is not built, as the
zola servecommand fails.This is fixed by introducing an additional boolean variable
clients_builtin the client's page frontmatter, which is set to false by default, but updates to be true when running theinit_topics_and_clients.shscript successfully. The page loads only if this var is set to true, otherwise a "Clients page not found" message is displayed, similar to the behavior in the commands and topics documentation.Issues Resolved
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.