[DRAFT] Added classes to vmsdk to better suport info fields #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Samuels <[email protected]>
Signed-off-by: Allen Samuels <[email protected]>
* Renamed valkey-extensions to valkey-bundle Signed-off-by: Nikhil Manglore <[email protected]>
* link: instructions to build Valkey from source Signed-off-by: Josh Soref <[email protected]>
yairgott
reviewed
Jun 27, 2025
vmsdk/src/info.cc
Outdated
| void DoSection(RedisModuleInfoCtx *ctx, absl::string_view section, int for_crash_report) { | ||
| if (RedisModule_InfoAddSection(ctx, section.data()) == REDISMODULE_ERR) { | ||
| VMSDK_LOG(DEBUG, nullptr) << "Info Section " << section << " Skipped"; | ||
| } else { |
There was a problem hiding this comment.
Avoid indentations by early return
Signed-off-by: Eran Ifrah <[email protected]>
* Rebranding module to use Valkey instead of Redis fixes: valkey-io#5 Signed-off-by: Yana Molodetsky <[email protected]>
* link: instructions to build Valkey from source Signed-off-by: Josh Soref <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting review. Please read the comment block at the top of info.h for details.
This has been manually tested at this point, the full up PR will add some automatic testing.
I've modified one of the existing INFO fields to both fix the crash vs memory allocation bug plus serve as a test-case for the syntax, etc.