Update comment in cluster_legacy.h#277
Merged
Merged
Conversation
enjoy-binbin
approved these changes
Apr 10, 2024
Contributor
Author
Neat! I believe I signed it correctly now, but am unsure how to rerun the test - is this something you do or do I need to create a new PR? |
Member
|
you can see the detail git commit message in your commit, it did not signoff. you can take a look in the unstable branch commit, all commits have a |
Member
|
@bentotten The easier thing you can do while on the patch-2 branch is: If you have git setup to add your name. That will add the signoff. |
Update comment suggesting clusterMsgPingExtTypes to clusterMsgPingtypes as clusterMsgPingExtTypes does not exist. Additionally specify that ver is set to CLUSTER_PROTO_VER, not "1", to make it easier to see where to change this. Signed-off-by: Ben Totten <btotten@amazon.com>
Contributor
Author
|
Complete (I think) Note: additional comment improvement for |
madolson
approved these changes
Apr 11, 2024
zuiderkwast
pushed a commit
to zuiderkwast/valkey
that referenced
this pull request
Apr 17, 2024
Update comment suggesting clusterMsgPingExtTypes to clusterMsgPingtypes as clusterMsgPingExtTypes does not exist Signed-off-by: Ben Totten <btotten@amazon.com>
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
Update comment suggesting clusterMsgPingExtTypes to clusterMsgPingtypes as clusterMsgPingExtTypes does not exist Signed-off-by: Ben Totten <btotten@amazon.com>
bjosv
added a commit
to bjosv/valkey
that referenced
this pull request
Feb 16, 2026
Squashed 'deps/libvalkey/' changes from b012f8e85..62e757d17 62e757d17 Release 0.3.0 (valkey-io#283) a554f0942 Fix potential uint32_t underflow issue (valkey-io#280) 8f9051ae0 Correcting command parser bug (valkey-io#277) 29023eb36 Add valkey-json, valkey-bloom, valkey-search to cmddef.h ae756bc89 Update cmddef.h to Valkey 9.0.0 21abd737e Replace problematic alloca() with fixed stack alloc 38191079c Fix compilation on Solaris with Sun/Solaris Studio ef5de0312 Make libvalkey initialization thread-safe ae341dea5 Support slotmap updates using CLUSTER NODES in RESP3 (valkey-io#262) 36f6e2292 Fix the long-blocking read for Valkey RDMA. (valkey-io#233) c090c28be Use a uintptr_t hop for casting pointers to ints daa7f11ac Avoid heap buffer overflow in valkeyAsyncFormattedCommand (valkey-io#245) 15974930d Add option to select a logical database (valkey-io#244) 983d67e4f Install the macosx adapter on Apple platforms only ... git-subtree-dir: deps/libvalkey git-subtree-split: 62e757d174748642ddd0cefad1ebae3941a6bb92 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
bjosv
added a commit
to bjosv/valkey
that referenced
this pull request
Feb 23, 2026
Squashed 'deps/libvalkey/' changes from b012f8e85..45c2ed15c 45c2ed15c Release 0.4.0 (valkey-io#286) 40d6590d7 Implement runtime dynamic loading for RDMA libraries (valkey-io#284) 62e757d17 Release 0.3.0 (valkey-io#283) a554f0942 Fix potential uint32_t underflow issue (valkey-io#280) 8f9051ae0 Correcting command parser bug (valkey-io#277) 29023eb36 Add valkey-json, valkey-bloom, valkey-search to cmddef.h ae756bc89 Update cmddef.h to Valkey 9.0.0 21abd737e Replace problematic alloca() with fixed stack alloc 38191079c Fix compilation on Solaris with Sun/Solaris Studio ef5de0312 Make libvalkey initialization thread-safe ae341dea5 Support slotmap updates using CLUSTER NODES in RESP3 (valkey-io#262) 36f6e2292 Fix the long-blocking read for Valkey RDMA. (valkey-io#233) c090c28be Use a uintptr_t hop for casting pointers to ints daa7f11ac Avoid heap buffer overflow in valkeyAsyncFormattedCommand (valkey-io#245) 15974930d Add option to select a logical database (valkey-io#244) 983d67e4f Install the macosx adapter on Apple platforms only ... git-subtree-dir: deps/libvalkey git-subtree-split: 45c2ed15cab9fa0ea1a6cabc8460f5eea6240de5 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
zuiderkwast
pushed a commit
that referenced
this pull request
Feb 23, 2026
Update deps/libvalkey to version 0.4.0 Squashed 'deps/libvalkey/' changes from b012f8e85..45c2ed15c 45c2ed15c Release 0.4.0 (#286) 40d6590d7 Implement runtime dynamic loading for RDMA libraries (#284) 62e757d17 Release 0.3.0 (#283) a554f0942 Fix potential uint32_t underflow issue (#280) 8f9051ae0 Correcting command parser bug (#277) 29023eb36 Add valkey-json, valkey-bloom, valkey-search to cmddef.h ae756bc89 Update cmddef.h to Valkey 9.0.0 21abd737e Replace problematic alloca() with fixed stack alloc 38191079c Fix compilation on Solaris with Sun/Solaris Studio ef5de0312 Make libvalkey initialization thread-safe ae341dea5 Support slotmap updates using CLUSTER NODES in RESP3 (#262) 36f6e2292 Fix the long-blocking read for Valkey RDMA. (#233) c090c28be Use a uintptr_t hop for casting pointers to ints daa7f11ac Avoid heap buffer overflow in valkeyAsyncFormattedCommand (#245) 15974930d Add option to select a logical database (#244) 983d67e4f Install the macosx adapter on Apple platforms only ... git-subtree-dir: deps/libvalkey git-subtree-split: 45c2ed15cab9fa0ea1a6cabc8460f5eea6240de5 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
Update deps/libvalkey to version 0.4.0 Squashed 'deps/libvalkey/' changes from b012f8e85..45c2ed15c 45c2ed15c Release 0.4.0 (valkey-io#286) 40d6590d7 Implement runtime dynamic loading for RDMA libraries (valkey-io#284) 62e757d17 Release 0.3.0 (valkey-io#283) a554f0942 Fix potential uint32_t underflow issue (valkey-io#280) 8f9051ae0 Correcting command parser bug (valkey-io#277) 29023eb36 Add valkey-json, valkey-bloom, valkey-search to cmddef.h ae756bc89 Update cmddef.h to Valkey 9.0.0 21abd737e Replace problematic alloca() with fixed stack alloc 38191079c Fix compilation on Solaris with Sun/Solaris Studio ef5de0312 Make libvalkey initialization thread-safe ae341dea5 Support slotmap updates using CLUSTER NODES in RESP3 (valkey-io#262) 36f6e2292 Fix the long-blocking read for Valkey RDMA. (valkey-io#233) c090c28be Use a uintptr_t hop for casting pointers to ints daa7f11ac Avoid heap buffer overflow in valkeyAsyncFormattedCommand (valkey-io#245) 15974930d Add option to select a logical database (valkey-io#244) 983d67e4f Install the macosx adapter on Apple platforms only ... git-subtree-dir: deps/libvalkey git-subtree-split: 45c2ed15cab9fa0ea1a6cabc8460f5eea6240de5 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update comment suggesting clusterMsgPingExtTypes to clusterMsgPingtypes as clusterMsgPingExtTypes does not exist