Adds workflows to build release binaries and push to S3 #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roshan Khatri <[email protected]>
Signed-off-by: Roshan Khatri <[email protected]>
roshkhatri
force-pushed
the
revamp-workflows
branch
from
4a41c8f to
c3e9a10
Compare
zuiderkwast
reviewed
Apr 12, 2024
hpatro
reviewed
Apr 12, 2024
I have tested the binaries on my ec2 and the uploads are tested by pushing the binaries to private s3 bucket. If we want to change any configurations of how we build we can make changes to the workflows to adapt that. |
Signed-off-by: Roshan Khatri <[email protected]>
Signed-off-by: Roshan Khatri <[email protected]>
roshkhatri
force-pushed
the
revamp-workflows
branch
from
d7406e8 to
deeb9a8
Compare
|
Now this Workflow will be triggered when a release has been published Also updated the top comment. |
hpatro
approved these changes
Apr 16, 2024
madolson
reviewed
Apr 16, 2024
Signed-off-by: Roshan Khatri <[email protected]>
Signed-off-by: Roshan Khatri <[email protected]>
madolson
reviewed
Apr 16, 2024
| with: | ||
| arch: aarch64 | ||
| distro: ${{matrix.distro.target}} | ||
| install: apt-get update && apt-get install -y build-essential libssl-dev libjemalloc-dev |
There was a problem hiding this comment.
Why are you including libejemalloc-dev? We aren't linking against it.
madolson
reviewed
Apr 16, 2024
|
|
||
| - name: Configure AWS credentials | ||
| run: | | ||
| aws configure set region us-east-1 |
There was a problem hiding this comment.
I think the bucket was in us-west-2? Does this even matter?
There was a problem hiding this comment.
But I will change to the correct location
| jobs: | ||
| build-valkey: | ||
| # Capture source tarball and generate checksum for it | ||
| name: Build package ${{ matrix.distro.target }} ${{ matrix.distro.arch }} |
There was a problem hiding this comment.
Suggested change
| name: Build package ${{ matrix.distro.target }} ${{ matrix.distro.arch }} | |
| name: Build package ${{ matrix.distro.target }} ${{ matrix.distro.arch }} |
| @@ -0,0 +1,79 @@ | |||
| name: Reusable workflow to build binary packages into S3 bucket | |||
There was a problem hiding this comment.
This isn't really that re-usable if it's only used for linux.
There was a problem hiding this comment.
This can also be used to build Nightly/Weekly build. I will remove it from the description for now, might add it later.
| ref: ${{ inputs.version }} | ||
|
|
||
| - name: Install dependencies | ||
| run: sudo apt-get update && sudo apt-get install -y build-essential libssl-dev jq wget |
There was a problem hiding this comment.
Seems weird we wouldn't install aws cli here as well.
| run: sudo apt-get update && sudo apt-get install -y build-essential libssl-dev jq wget | ||
|
|
||
| - name: Set JEMALLOC Flags | ||
| run: JEMALLOC_CONFIGURE_OPTS="--with-lg-page=16" |
There was a problem hiding this comment.
Why are we configuring the lg-page to be 16? This will use more memory.
There was a problem hiding this comment.
Yes just realized it may also increase chances of fragmentation I guess. Removing this.
Signed-off-by: Roshan Khatri <[email protected]>
bjosv
reviewed
Apr 16, 2024
bjosv
reviewed
Apr 16, 2024
Signed-off-by: Roshan Khatri <[email protected]>
Signed-off-by: Roshan Khatri <[email protected]>
madolson
approved these changes
Apr 16, 2024
zuiderkwast
pushed a commit
to zuiderkwast/placeholderkv
that referenced
this pull request
Apr 17, 2024
[related to](valkey-io#230) Adds workflows to build Valkey binaries and push to S3 to make it available to download from the website The Workflows can be triggered by pushing a release to the repo and the other option is manually by one of the Maintainers. Once the workflow triggers, it will generate a matrix of Jobs for the platforms we need to build from `utils/releasetools/build-config.json` and then the respective Jobs are triggered. These jobs make Valkey with respect to the platform binaries we want to release and would push to a private S3 bucket. --------- Signed-off-by: Roshan Khatri <[email protected]>
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
[related to](valkey-io#230) Adds workflows to build Valkey binaries and push to S3 to make it available to download from the website The Workflows can be triggered by pushing a release to the repo and the other option is manually by one of the Maintainers. Once the workflow triggers, it will generate a matrix of Jobs for the platforms we need to build from `utils/releasetools/build-config.json` and then the respective Jobs are triggered. These jobs make Valkey with respect to the platform binaries we want to release and would push to a private S3 bucket. --------- Signed-off-by: Roshan Khatri <[email protected]>
roshkhatri
added a commit
to roshkhatri/valkey
that referenced
this pull request
Jul 31, 2024
[related to](valkey-io#230) Adds workflows to build Valkey binaries and push to S3 to make it available to download from the website The Workflows can be triggered by pushing a release to the repo and the other option is manually by one of the Maintainers. Once the workflow triggers, it will generate a matrix of Jobs for the platforms we need to build from `utils/releasetools/build-config.json` and then the respective Jobs are triggered. These jobs make Valkey with respect to the platform binaries we want to release and would push to a private S3 bucket. --------- Signed-off-by: Roshan Khatri <[email protected]>
roshkhatri
added a commit
to roshkhatri/valkey
that referenced
this pull request
Jul 31, 2024
[related to](valkey-io#230) Adds workflows to build Valkey binaries and push to S3 to make it available to download from the website The Workflows can be triggered by pushing a release to the repo and the other option is manually by one of the Maintainers. Once the workflow triggers, it will generate a matrix of Jobs for the platforms we need to build from `utils/releasetools/build-config.json` and then the respective Jobs are triggered. These jobs make Valkey with respect to the platform binaries we want to release and would push to a private S3 bucket. --------- Signed-off-by: Roshan Khatri <[email protected]>
madolson
pushed a commit
that referenced
this pull request
Sep 30, 2024
…315) (#857) [related to](#230) Adds workflows to build Valkey binaries and push to S3 to make it available to download from the website The Workflows can be triggered by pushing a release to the repo and the other option is manually by one of the Maintainers. Once the workflow triggers, it will generate a matrix of Jobs for the platforms we need to build from `utils/releasetools/build-config.json` and then the respective Jobs are triggered. These jobs make Valkey with respect to the platform binaries we want to release and would push to a private S3 bucket. --------- Signed-off-by: Roshan Khatri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
Adds workflows to build Valkey binaries and push to S3 to make it available to download from the website
I have commented the macOS build code as we need code-sign the binaries for Mac and need more info on that.
The Workflows can be triggered by pushing a release to the repo and the other option is manually by one of the Maintainers. For example:
Once the workflow triggers, it will generate a matrix of Jobs for the platforms we need to build from
utils/releasetools/build-config.jsonand then the respective Jobs are triggered. These jobs make Valkey with respect to the platform binaries we want to release and would push to a private S3 bucket.