Skip to content

Replace clang-format with AStyle for code formatting#3560

Closed
harrylin98 wants to merge 1 commit into
valkey-io:unstablefrom
harrylin98:astyle
Closed

Replace clang-format with AStyle for code formatting#3560
harrylin98 wants to merge 1 commit into
valkey-io:unstablefrom
harrylin98:astyle

Conversation

@harrylin98

@harrylin98 harrylin98 commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

This is a prototype PR to address the issue #3450

clang-format is too prescriptive, it actively removes intentional alignment (column-aligned declarations, assignments, multi-line conditions) rather than leaving them alone.

AStyle is less aggressive and preserves developer formatting choices while still enforcing consistent indentation, spacing, and pointer alignment.

Commits:

  1. Replace clang-format with AStyle (config, CI workflow, docs)
  2. TODO: Apply AStyle formatting to all source and unit test files under src/

Signed-off-by: harrylin98 <harrylin980107@gmail.com>
@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.36%. Comparing base (d2db0c2) to head (11c8eff).
⚠️ Report is 11 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #3560   +/-   ##
=========================================
  Coverage     76.35%   76.36%           
=========================================
  Files           159      159           
  Lines         80054    80054           
=========================================
+ Hits          61125    61131    +6     
+ Misses        18929    18923    -6     

see 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@madolson madolson closed this Apr 28, 2026
@harrylin98 harrylin98 deleted the astyle branch June 3, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants