Migrate to new control flow syntax#1827
Conversation
|
Damned! E2e tests are flaky after all 😭 ... any suggestions ? Out of topic, but you mentioned migrating to signals. I would suggest to release what we have now, without signals. And introduce signals in the next version. Because signals are still a bit young, so probably not everyone is familiar with yet. And because output signals are still missing. I feel it would be weird if we migrate to input signals now, and later migrate to output signals. While it's definitely something we should in mid-long term, I feel we can still postpone a bit. WDTY ? |
Yes sure, I just want to have the unit-tests working again first, I think I will revert the jest migration someone else had merged to master. EDIT: I guess the flakyness could be caused by the linux version used, i generate the screenshots using docker and the @PowerKiKi can you give the docs a once-over and perhaps add a migration guide to v6 🙏 ? |
|
Thank you for the release 🚀
I noticed the content of README.md and PS: https://valor-software.com/ng2-charts/ was not updated correctly with the last release:
|
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ng2-charts](https://github.com/valor-software/ng2-charts) | [`^5.0.3` -> `^6.0.0`](https://renovatebot.com/diffs/npm/ng2-charts/5.0.4/6.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>valor-software/ng2-charts (ng2-charts)</summary> ### [`v6.0.0`](https://github.com/valor-software/ng2-charts/releases/tag/v6.0.0) [Compare Source](valor-software/ng2-charts@v5.0.4...v6.0.0) #### What’s Changed - BREAKING Tree shakable standalone library ([#​1801](valor-software/ng2-charts#1801)) [@​PowerKiKi](https://github.com/PowerKiKi) Users must import the library in standalone mode - BREAKING drop hardcoded and generated colors ([#​1806](valor-software/ng2-charts#1806)) [@​PowerKiKi](https://github.com/PowerKiKi) Users must migrate to the Colors [plugin](https://www.chartjs.org/docs/latest/general/colors.html) from Chart.js for color generation - Angular 17 ([#​1757](valor-software/ng2-charts#1757)) [@​santam85](https://github.com/santam85) Angular 17 is the minimum version for v6 - Target ES2022 as is done in Angular 17 new projects ([#​1802](valor-software/ng2-charts#1802)) [@​PowerKiKi](https://github.com/PowerKiKi) - Enforce prettier in CI ([#​1804](valor-software/ng2-charts#1804)) [@​PowerKiKi](https://github.com/PowerKiKi) - Drop CHANGELOG.md ([#​1805](valor-software/ng2-charts#1805)) [@​PowerKiKi](https://github.com/PowerKiKi) - Migrate to new control flow syntax ([#​1827](valor-software/ng2-charts#1827)) [@​PowerKiKi](https://github.com/PowerKiKi) - Make defaults type safe ([#​1836](valor-software/ng2-charts#1836)) [@​Cselt](https://github.com/Cselt) - chore(deps-dev): bump [@​types/node](https://github.com/types/node) from 20.11.23 to 20.11.24 ([#​1857](valor-software/ng2-charts#1857)) [@​dependabot](https://github.com/dependabot) - chore(deps-dev): bump [@​types/node](https://github.com/types/node) from 20.11.20 to 20.11.21 ([#̴...
2 participants
No description provided.