Skip to content

Angular 20 upgrade #6757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

Conversation

dezsiszabi
Copy link
Contributor

@dezsiszabi dezsiszabi commented Jun 14, 2025

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

There were a lot of peer dependency issues in the project, npm install should now work without --legacy-peer-deps.

FYI: At some point a bigger eslint upgrade is needed... They like to remove/move/modify rules a lot... Especially with the later @stylistic changes...

@MatthiasHuygelen
Copy link
Contributor

@valorkin Any updates on when this will be merged ?

@valorkin valorkin requested a review from Copilot June 26, 2025 20:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Upgrade the project and all its packages to Angular 20 and align ESLint configs with the new tooling.

  • Bump all package versions and Angular/NX dependency versions to 20.x
  • Remove per-package plugin:@nx/angular in ESLint overrides and add it once in the root config
  • Update lint suppression in type-checks.ts and add a new compatibility row in the README

Reviewed Changes

Copilot reviewed 76 out of 77 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/*/package.json Bump each module’s version to 20.0.0
package.json Upgrade root version to 20.0.0 and bump Angular/NX dependencies
src/*/.eslintrc.json Remove outdated plugin:@nx/angular extends
.eslintrc.json Add plugin:@nx/angular in root extends and update rules
src/chronos/utils/type-checks.ts Change lint-disable from ban-types to no-unsafe-function-type
README.md Add Angular 20 compatibility row
Comments suppressed due to low confidence (3)

package.json:3

  • [nitpick] You’ve updated many dependencies to Angular 20, but I don’t see new or updated tests validating Angular 20 compatibility. Consider adding an integration or compilation test suite against Angular 20 to catch regressions early.
  "version": "20.0.0",

README.md:182

  • [nitpick] Verify that the new table row aligns correctly with the separators and renders cleanly in Markdown; mismatched column widths can break table formatting in some renderers.
| 20.x.x        | 20.x.x          | 5.x.x or 4.x.x          |

src/chronos/utils/type-checks.ts:19

  • The lint directive now disables no-unsafe-function-type, but the original intent was to allow use of the Function type (which is covered by @typescript-eslint/ban-types). Consider reverting to // eslint-disable-next-line @typescript-eslint/ban-types to ensure the helper compiles without errors.
// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type

@dezsiszabi
Copy link
Contributor Author

Any update on this?

1 similar comment
@Brown-Dan
Copy link

Any update on this?

@lexasq
Copy link
Contributor

lexasq commented Jun 30, 2025

@dezsiszabi hi, thanks a lot for your contribution. I'll review and verify if everything is still works as it was before.

@lexasq
Copy link
Contributor

lexasq commented Jul 2, 2025

Looks good to me, working on a rollout.

@lexasq lexasq merged commit 17b4330 into valor-software:development Jul 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants