Slightly improve the way database queries are represented in logging metadata #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 1.52.1
While this has no visible impact when using the "default"
StreamLogHandler, it becomes quite visible when using smarter log handlers which respect the structural representation afforded byLogger.MetadataValue.For example, with
StreamLogHandler, with or without these changes, a given query might get logged like this:With a smarter log handler (an only slightly modified version of
StreamLogHandlerin fact), but without these changes, it looks like this:Notice that
"1"is in quotes and""AA""is double-quoted. But with these changes, and the modified handler, the log now looks like this: