feat: new component tour #1875
Open
feat: new component tour #1875
+2,162
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@cszhjh is attempting to deploy a commit to the varletjs Team on Vercel. A member of the Team first needs to authorize it. |
@varlet/cli
@varlet/icons
@varlet/import-resolver
@varlet/preset-tailwindcss
@varlet/preset-unocss
@varlet/touch-emulator
@varlet/shared
@varlet/ui
@varlet/use
@varlet/vite-plugins
commit: |
|
总体感觉非常好，几个修改意见：
|
haoziqaq
reviewed
May 5, 2025
Comment on lines
+20
to
+43
| function flattedChildren(subTree: any) { | ||
| const vNodes: VNode[] = [] | ||
|
|
||
| const flat = (subTree: any) => { | ||
| if (subTree?.component) { | ||
| flat(subTree?.component.subTree) | ||
| return | ||
| } | ||
|
|
||
| if (isArray(subTree?.children)) { | ||
| subTree.children.forEach((child: any) => { | ||
| if (isVNode(child)) { | ||
| vNodes.push(child) | ||
|
|
||
| flat(child) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| flat(subTree) | ||
|
|
||
| return vNodes | ||
| } |
| const total = result.length | ||
|
|
||
| if (cacheTotal !== total) { | ||
| emit('update-total', total) |
There was a problem hiding this comment.
最好是不要在渲染函数里 emit 事件，建议改成 useChildren useParent
haoziqaq
reviewed
May 5, 2025
| } | ||
|
|
||
| export const props = { | ||
| open: Boolean, |
| export const props = { | ||
| target: [String, Object] as PropType<string | HTMLElement>, | ||
| title: String, | ||
| description: String, |
|
TourSteps 这个组件可以考虑一下使用 useChildren useParent 之后，是否还是必要的。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
List of tasks you have already done and plan to do.
Change information
Describe your modifications here.
Issues
close #1797
Related Links
Links related to this pr.