fix coverage please

Author: fswair

tests/acpremote/test_helpers.py

@@ -625,6 +625,80 @@ async def test_command_process_terminate_timeout_kills() -> None:
     assert process.returncode == -9
 
 
+@pytest.mark.asyncio
+async def test_command_process_terminate_returns_when_already_exited() -> None:
+    process = _FakeCommandProcess(returncode=0)
+
+    await command_module._terminate_process(cast(Any, process), timeout=0.001)
+
+    assert process.terminate_calls == 0
+    assert process.kill_calls == 0
+
+
+@pytest.mark.asyncio
+async def test_command_process_terminate_returns_when_timeout_sets_returncode() -> None:
+    @dataclass(slots=True)
+    class _ExitingOnCancelledProcess(_FakeCommandProcess):
+        async def wait(self) -> int:
+            try:
+                await asyncio.sleep(1)
+            except asyncio.CancelledError:
+                self.returncode = 143
+                raise
+            return self.returncode or 0  # pragma: no cover
+
+    process = _ExitingOnCancelledProcess()
+
+    await command_module._terminate_process(cast(Any, process), timeout=0.001)
+
+    assert process.terminate_calls == 1
+    assert process.kill_calls == 0
+    assert process.returncode == 143
+
+
+@pytest.mark.asyncio
+async def test_command_process_terminate_kills_when_cancelled() -> None:
+    process = _FakeCommandProcess(wait_delay=0.01)
+    task = asyncio.create_task(
+        command_module._terminate_process(cast(Any, process), timeout=1),
+    )
+
+    await asyncio.sleep(0)
+    task.cancel()
+    with pytest.raises(asyncio.CancelledError):
+        await task
+
+    assert process.terminate_calls == 1
+    assert process.kill_calls == 1
+
+
+@pytest.mark.asyncio
+async def test_command_process_terminate_cancelled_after_process_exit() -> None:
+    @dataclass(slots=True)
+    class _ExitedOnCancelledProcess(_FakeCommandProcess):
+        async def wait(self) -> int:
+            try:
+                await asyncio.sleep(1)
+            except asyncio.CancelledError:
+                self.returncode = 0
+                raise
+            return self.returncode or 0  # pragma: no cover
+
+    process = _ExitedOnCancelledProcess()
+    task = asyncio.create_task(
+        command_module._terminate_process(cast(Any, process), timeout=1),
+    )
+
+    await asyncio.sleep(0)
+    task.cancel()
+    with pytest.raises(asyncio.CancelledError):
+        await task
+
+    assert process.terminate_calls == 1
+    assert process.kill_calls == 0
+    assert process.returncode == 0
+
+
 @pytest.mark.asyncio
 async def test_command_connection_covers_all_done_path(
     monkeypatch: pytest.MonkeyPatch,

tests/codex_auth_helper/test_auth.py

@@ -2,7 +2,6 @@
 
 import asyncio
 import json
-import os
 import stat
 from datetime import UTC, datetime, timedelta
 from pathlib import Path
@@ -24,7 +23,7 @@
     _parse_timestamp,
     _require_str,
 )
-from codex_auth_helper.auth.store import CodexAuthStore
+from codex_auth_helper.auth.store import CodexAuthStore, _fsync_directory
 
 from .support import write_auth_file
 
@@ -179,8 +178,7 @@ def test_auth_store_covers_invalid_json_non_object_and_write_round_trip(
     store.write_state(updated_state)
     persisted = json.loads(auth_path.read_text(encoding="utf-8"))
     assert persisted["tokens"]["account_id"] == "acct_written"
-    if os.name == "posix":
-        assert stat.S_IMODE(auth_path.stat().st_mode) == 0o600
+    assert stat.S_IMODE(auth_path.stat().st_mode) == 0o600
 
     failed_state = CodexAuthState(
         access_token=state.access_token,
@@ -201,6 +199,13 @@ def test_auth_store_covers_invalid_json_non_object_and_write_round_trip(
     assert persisted_after_failure["tokens"]["account_id"] == "acct_written"
     assert not list(auth_path.parent.glob(f".{auth_path.name}.*.tmp"))
 
+    with pytest.MonkeyPatch.context() as monkeypatch:
+        monkeypatch.setattr(
+            "codex_auth_helper.auth.store.os.open",
+            lambda *_args, **_kwargs: (_ for _ in ()).throw(OSError("open failed")),
+        )
+        _fsync_directory(auth_path.parent)
+
 
 @pytest.mark.asyncio
 async def test_token_manager_helpers_cover_non_refresh_and_close_paths(