fix(tests): Fix uptime_metrics GraphQL/API tests #4187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lee Benson <[email protected]>
leebenson
added
type: bug
sghall
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Looks good @leebenson 👍 Didn't get any failures locally with this.
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
Signed-off-by: Lee Benson <[email protected]> Signed-off-by: Brian Menges <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4175 (hopefully.)
Test with:
RUST_TEST_THREADS=X cargo test --test api -- --nocaptureWhere 'X' is the number of threads to test. CI was balking at
1; my local machine panicked with2. If both pass, it probably works.Signed-off-by: Lee Benson [email protected]