Upgrade deno

[mgilbir]

No description provided.

[jonmmease]

Thanks for getting this started. For the bundle-license and codegen-clean failures see https://github.com/vega/vl-convert/blob/main/DEVELOP.md.

I'm not sure why the bundled JavaScript dependencies have changes, but maybe skypack has changed their formatting.

[mgilbir]

Deno v2 has deprecated the deno vendor command. I'm looking into it but they now do something funny with the folder names that requires some tweaking.

[mgilbir]

Finally all tests are passing.

The code around the codegen is not pretty. My priority was to get it back to a working state.

In order to do that I renamed all the files and directories to the same structure that they had when using the deno vendor tool using the information that is available in the new vl-convert-rs/vendor/manifest.json and vl-convert-rs/deno.lock files.

I think there are ways to simplify/optimize it all, but I leave it up to you to decide how to proceed.

[jonmmease]

Thanks @mgilbir, I'll give this a look this weekend.

Out of curiosity, if you don't mind sharing, do you have a use-case that requires Deno 2 compatibility?

[mgilbir]

Thanks and no rush from my end. The code is probably horrible as I’m quite new to rust. It could be that I’m completely wrong and the project is better off staying on deno 1, but I have been working in my free time since the summer on another PR that handles data in local files. It works on my machine but there are some CI tests failing that I don’t understand. I have the feeling that it would be easier to build it on top of deno2.

…

On Thu, 26 Dec 2024 at 16:12, Jon Mease ***@***.***> wrote: Thanks @mgilbir <https://github.com/mgilbir>, I'll give this a look this weekend. Out of curiosity, if you don't mind sharing, do you have a use-case that requires Deno 2 compatibility? — Reply to this email directly, view it on GitHub <#205 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABI5JDNSCBP6GFAQCBJPK32HQMFDAVCNFSM6AAAAABUBYWZM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRSHA3TMNBRGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>