Implement ValuesOfCorrectType validator#18
Merged
Conversation
vektah
changed the title
vektah
force-pushed
the
values-of-correct-type
branch
3 times, most recently
from
9241421 to
813033e
Compare
vektah
force-pushed
the
values-of-correct-type
branch
from
813033e to
d13dcfb
Compare
Owner
Author
|
Still a few failing tests around default variables, but I'm going to ship as is. Codecov decrease is from utility methods in ast. Going to leave it until I have a chance to do a general type system cleanup. |
StevenACoffman
pushed a commit
that referenced
this pull request
Jan 31, 2022
fix(validate): fix race condition in rules sort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is going to be a big one