validator: make rules exported and allow custom set of rules for Validate#320
Merged
StevenACoffman merged 2 commits intovektah:masterfrom Sep 26, 2024
kgrigorev:export_validator_rules
Merged
validator: make rules exported and allow custom set of rules for Validate#320StevenACoffman merged 2 commits intovektah:masterfrom kgrigorev:export_validator_rules
StevenACoffman merged 2 commits intovektah:masterfrom
kgrigorev:export_validator_rules
Conversation
…d to the Validate
Collaborator
|
Thanks! One thing to note is that changing the package variable will not be safe for tests that run in parallel, as well as in production code. |
This was referenced Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validator.Validate function uses predefined set of rules, which are populated during package initialisation. While it is possible to add custom rules via AddRule, it is not possible to have completely customised set of rules (e.g. if someone wants to delete or replace some predefined rule). The javascript implementation allows to pass custom set of rules and falls back to the default set only if the parameter is null (https://github.com/graphql/graphql-js/blob/bd2fe71d2a7ca8619ec71bae919692ce61e10958/src/validation/validate.ts#L40). This PR converts every rule to the package-level variable and allows to pass custom set of rules to the Validate function as varargs. It also falls back to predefined set of rules for the backward compatibility, so that none of the existing code is broken. With that change validation can be customized:
Describe your PR and link to any relevant issues.
I have: