Update GraphQL spec to Septemper 2025 version#401
Merged
StevenACoffman merged 2 commits intomasterfrom Apr 24, 2026
Merged
Conversation
2 tasks
StevenACoffman
force-pushed
the
update_graphqljs_v16_12_0
branch
from
be54753 to
213a468
Compare
|
coverage: 87.245% (+0.1%) from 87.113% — update_graphqljs_v16_12_0 into master |
StevenACoffman
force-pushed
the
update_graphqljs_v16_12_0
branch
from
213a468 to
b5206e8
Compare
Signed-off-by: Steve Coffman <steve@khanacademy.org>
Signed-off-by: Steve Coffman <steve@khanacademy.org> # Conflicts: # validator/rules/values_of_correct_type.go
StevenACoffman
force-pushed
the
update_graphqljs_v16_12_0
branch
from
b5206e8 to
4b2d25d
Compare
Collaborator
Author
|
@fredzqm Can you please verify that this doesn't regress your use case? |
Collaborator
Author
|
@AlexanderArvidsson this moves things closer to fully aligned with 2023 spec and latest graphql-js reference implementation, although there are some gaps identified for the SDL validation as noted above. i could use help! |
StevenACoffman
changed the title
Contributor
|
Thanks for tagging me Steven! Yeah, amazing update! Would love to make use of @OneOf soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated spec target:
September 2025 and select portions of the Draft, based on the graphql-js reference implementation graphql-js v16.13.2. This includes Schema definition language, block strings as descriptions, error paths & extension, etc. If there is a spec update or new release, please follow this process to update and submit a PR.
Process followed:
I also did a comparison of the graphql-js SDL Validation pluggable rules to the gqlparser rules that SDL validate imperatively in ValidateSchemaDocument in schema.go, at schema load time and checked that gap analysis in as WIP.md
Signed-off-by: Steve Coffman steve@khanacademy.org