Skip to content

Update chokidar to latest #18995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2020
Merged

Update chokidar to latest #18995

merged 3 commits into from
Nov 11, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 9, 2020

Updates to the latest version of chokidar

x-ref: #17416

@ijjk ijjk added the type: next label Nov 9, 2020
@vercel vercel bot temporarily deployed to Preview November 9, 2020 20:07 Inactive
@ijjk
Copy link
Member Author

ijjk commented Nov 9, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/chokidar Change
buildDuration 12.4s 12.3s -100ms
nodeModulesSize 85 MB 84.8 MB -208 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/chokidar Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.386 2.359 -0.03
/ avg req/sec 1047.58 1059.9 +12.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.215 1.252 ⚠️ +0.04
/error-in-render avg req/sec 2057.51 1996.63 ⚠️ -60.88
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/chokidar Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6a509b2..b31a.js gzip 7.4 kB 7.4 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.4 kB 58.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js update/chokidar Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0547acd..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/chokidar Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/chokidar Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js update/chokidar Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/chokidar Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/chokidar Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/chokidar Change
buildDuration 14.2s 14.2s ⚠️ +71ms
nodeModulesSize 85 MB 84.8 MB -208 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/chokidar Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6a509b2..b31a.js gzip 7.4 kB 7.4 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.4 kB 58.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js update/chokidar Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0547acd..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/chokidar Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/chokidar Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js update/chokidar Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/chokidar Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js update/chokidar Change
_error.js 915 kB 915 kB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 915 kB 915 kB ✓
link.js 964 kB 964 kB ✓
routerDirect.js 957 kB 957 kB ✓
withRouter.js 957 kB 957 kB ✓
Overall change 4.72 MB 4.72 MB ✓
Commit: cc5d08f

@vercel vercel bot temporarily deployed to Preview November 9, 2020 20:33 Inactive
@ijjk
Copy link
Member Author

ijjk commented Nov 9, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/chokidar Change
buildDuration 12.9s 13.1s ⚠️ +258ms
nodeModulesSize 85 MB 84.8 MB -208 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/chokidar Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.421 2.364 -0.06
/ avg req/sec 1032.81 1057.63 +24.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.303 1.294 -0.01
/error-in-render avg req/sec 1918.76 1931.92 +13.16
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/chokidar Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6a509b2..b31a.js gzip 7.4 kB 7.4 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.4 kB 58.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js update/chokidar Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0547acd..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/chokidar Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/chokidar Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js update/chokidar Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/chokidar Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/chokidar Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/chokidar Change
buildDuration 14.8s 14.7s -91ms
nodeModulesSize 85 MB 84.8 MB -208 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/chokidar Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6a509b2..b31a.js gzip 7.4 kB 7.4 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.4 kB 58.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js update/chokidar Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0547acd..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/chokidar Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/chokidar Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js update/chokidar Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/chokidar Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js update/chokidar Change
_error.js 915 kB 915 kB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 915 kB 915 kB ✓
link.js 964 kB 964 kB ✓
routerDirect.js 957 kB 957 kB ✓
withRouter.js 957 kB 957 kB ✓
Overall change 4.72 MB 4.72 MB ✓
Commit: 4c6c74e

@ijjk
Copy link
Member Author

ijjk commented Nov 11, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/chokidar Change
buildDuration 13.8s 14s ⚠️ +228ms
nodeModulesSize 85 MB 84.8 MB -208 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/chokidar Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.596 2.43 -0.17
/ avg req/sec 963.01 1028.64 +65.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.374 1.443 ⚠️ +0.07
/error-in-render avg req/sec 1818.95 1733.06 ⚠️ -85.89
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/chokidar Change
677f882d2ed8..3888.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-673683e..14c7.js gzip 7.48 kB 7.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.5 kB 58.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js update/chokidar Change
677f882d2ed8..dule.js gzip 7.05 kB 7.05 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0c7333c..dule.js gzip 6.47 kB 6.47 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/chokidar Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/chokidar Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js update/chokidar Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/chokidar Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/chokidar Change
index.html gzip 969 B 969 B ✓
link.html gzip 977 B 977 B ✓
withRouter.html gzip 963 B 963 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/chokidar Change
buildDuration 16.3s 16.3s -8ms
nodeModulesSize 85 MB 84.8 MB -208 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/chokidar Change
677f882d2ed8..3888.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-673683e..14c7.js gzip 7.48 kB 7.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.5 kB 58.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js update/chokidar Change
677f882d2ed8..dule.js gzip 7.05 kB 7.05 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0c7333c..dule.js gzip 6.47 kB 6.47 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/chokidar Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/chokidar Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js update/chokidar Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/chokidar Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js update/chokidar Change
_error.js 916 kB 916 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 916 kB 916 kB ✓
link.js 965 kB 965 kB ✓
routerDirect.js 958 kB 958 kB ✓
withRouter.js 958 kB 958 kB ✓
Overall change 4.72 MB 4.72 MB ✓
Commit: 8ba276e

@kodiakhq kodiakhq bot merged commit ae75c6a into vercel:canary Nov 11, 2020
@ijjk ijjk deleted the update/chokidar branch November 11, 2020 16:58
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @Timer