Remove anonymous default export rule from Babel #32763

timneutkens · 2021-12-23T12:08:43Z

We didn't port this plugin to next-swc given that the eslint setup warns for this automatically. Given that we still get issues opened for this particular warning coming from the plugin it'd be good to remove it.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

We didn't port this plugin to next-swc given that the eslint setup warns for this automatically. Given that we still get issues opened for this particular warning coming from the plugin it'd be good to remove it.

ijjk · 2021-12-23T12:34:14Z

Failing test suites

Commit: 8747b89

test/integration/no-anon-default-export/test/index.test.js

no anonymous default export warning > show correct warnings for page
no anonymous default export warning > show correct warnings for child
no anonymous default export warning > show correct warnings for both

Expand output

● no anonymous default export warning › show correct warnings for page

expect(received).toBeTruthy()

Received: false

  31 |
  32 |     const found = await check(() => stderr, /anonymous/i, false)
> 33 |     expect(found).toBeTruthy()
     |                       ^
  34 |     await browser.close()
  35 |
  36 |     expect(

  at Object.<anonymous> (integration/no-anon-default-export/test/index.test.js:33:23)

● no anonymous default export warning › show correct warnings for child

expect(received).toBeTruthy()

Received: false

  50 |     const app = await launchApp(appDir, appPort, {
  51 |       env: { __NEXT_TEST_WITH_DEVTOOL: true },
> 52 |       onStderr(msg) {
     |                      ^
  53 |         stderr += msg || ''
  54 |       },
  55 |     })

  at Object.<anonymous> (integration/no-anon-default-export/test/index.test.js:52:23)

● no anonymous default export warning › show correct warnings for both

expect(received).toBeTruthy()

Received: false

  69 |
  70 |     await killApp(app)
> 71 |   })
     |     ^
  72 |
  73 |   it('show correct warnings for both', async () => {
  74 |     let stderr = ''

  at Object.<anonymous> (integration/no-anon-default-export/test/index.test.js:71:23)

ijjk · 2021-12-23T17:18:08Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
buildDuration	16.7s	16.8s	⚠️ +133ms
buildDurationCached	3.7s	3.8s	⚠️ +95ms
nodeModulesSize	348 MB	348 MB	-6.79 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.358	3.387	⚠️ +0.03
/ avg req/sec	744.42	738.08	⚠️ -6.34
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.547	1.586	⚠️ +0.04
/error-in-render avg req/sec	1616.2	1576.05	⚠️ -40.15

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27 kB	27 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.9 kB	70.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.73 kB	4.73 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.13 kB	2.13 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
index.html gzip	533 B	533 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

Default Build with SWC (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
buildDuration	18.1s	18s	-118ms
buildDurationCached	3.7s	3.7s	-13ms
nodeModulesSize	348 MB	348 MB	-6.79 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.345	3.348	0
/ avg req/sec	747.28	746.75	⚠️ -0.53
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.541	1.574	⚠️ +0.03
/error-in-render avg req/sec	1621.82	1588.58	⚠️ -33.24

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	27.2 kB	27.2 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.1 kB	71.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.36 kB	2.36 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	906 B	906 B	✓
image-HASH.js gzip	4.75 kB	4.75 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/remove-babel-plugin	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: dd05efe

manudeli · 2022-01-22T22:08:00Z

@timneutkens Thank you for the fastest fixing!👍👍👍

slamapp/frontend#48
@limkhl 노체, Next팀이 12.0.8에서 이 룰을 삭제했네요
@grighth12 @Parkserim 한나랑 앤도 이 버그 해결된 이유 확인해주세요

12.0.7 에서 12.0.8 로 버전 업데이트하니까 해결됩니다.

머지되면 yarn install로 package.json 최신화해주세요

manudeli · 2022-01-22T22:17:49Z

@YuriGor Please check this PR 😎

This PR may proper answer for your discussion!
You and I may need to upgrade version of Next.js to 12.0.8 (latest version)

We didn't port this plugin to next-swc given that the eslint setup warns for this automatically. Given that we still get issues opened for this particular warning coming from the plugin it'd be good to remove it. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`

Remove anonymous default export rule from Babel

8747b89

We didn't port this plugin to next-swc given that the eslint setup warns for this automatically. Given that we still get issues opened for this particular warning coming from the plugin it'd be good to remove it.

timneutkens requested review from huozhi, ijjk, padmaia and shuding as code owners December 23, 2021 12:08

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 23, 2021

timneutkens mentioned this pull request Dec 23, 2021

Fix: Only warn about default naming when default export returns JSX #32636

Closed

10 tasks

This comment has been minimized.

Sign in to view

Delete test

86ca5cd

This comment has been minimized.

Sign in to view

ijjk approved these changes Dec 23, 2021

View reviewed changes

Merge branch 'canary' into fix/remove-babel-plugin

dd05efe

kodiakhq bot merged commit e377698 into vercel:canary Dec 23, 2021

snyk-bot mentioned this pull request Jan 21, 2022

[Snyk] Security upgrade antd from 4.3.0 to 4.17.0 MaxMood96/next.js#230

Open

manudeli mentioned this pull request Jan 22, 2022

yarn dev 명령어 실행 시 터미널 콘솔에 뜨는 익명 화살표 함수 warning, referenceerror 에러 해결 slamapp/frontend#49

Merged

github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove anonymous default export rule from Babel #32763

Remove anonymous default export rule from Babel #32763

Uh oh!

timneutkens commented Dec 23, 2021

Uh oh!

This comment has been minimized.

ijjk commented Dec 23, 2021

Uh oh!

This comment has been minimized.

ijjk commented Dec 23, 2021

Uh oh!

manudeli commented Jan 22, 2022 •

edited

Loading

Uh oh!

manudeli commented Jan 22, 2022 •

edited

Loading

Uh oh!

Uh oh!

Remove anonymous default export rule from Babel #32763

Remove anonymous default export rule from Babel #32763

Uh oh!

Conversation

timneutkens commented Dec 23, 2021

Bug

Feature

Documentation / Examples

Uh oh!

This comment has been minimized.

ijjk commented Dec 23, 2021

Failing test suites

Uh oh!

This comment has been minimized.

ijjk commented Dec 23, 2021

Stats from current PR

Uh oh!

manudeli commented Jan 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manudeli commented Jan 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

manudeli commented Jan 22, 2022 •

edited

Loading

manudeli commented Jan 22, 2022 •

edited

Loading