Refactor: Get rid of overly generic getExpectedRequestStore function
#81791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
unstubbable
force-pushed
the
hl/delete-get-expected-request-store
branch
from
1c46f4f to
af0f51a
Compare
unstubbable
changed the base branch from
graphite-base/81791
to
hl/vscode-types-tasks
This was referenced Jul 18, 2025
unstubbable
changed the base branch from
hl/vscode-types-tasks
to
graphite-base/81791
unstubbable
force-pushed
the
graphite-base/81791
branch
from
c993b14 to
298acda
Compare
unstubbable
force-pushed
the
hl/delete-get-expected-request-store
branch
from
af0f51a to
6d09840
Compare
unstubbable
force-pushed
the
hl/delete-get-expected-request-store
branch
from
6d09840 to
f5473d3
Compare
lubieowoce
reviewed
Jul 18, 2025
packages/next/src/server/web/spec-extension/adapters/request-cookies.ts
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #81791 will not alter performanceComparing Summary
|
The places in which we called `getExpectedRequestStore()` were already narrowing down the work unit store type to a request store. This allows us to delete the function, and call `throwForMissingRequestStore()` directly instead.
unstubbable
force-pushed
the
hl/delete-get-expected-request-store
branch
from
f5473d3 to
896ec59
Compare
lubieowoce
approved these changes
Jul 18, 2025
alii
pushed a commit
to Jarred-Sumner/next.js
that referenced
this pull request
Jul 21, 2025
vercel#81791) The places in which we called `getExpectedRequestStore()` were already narrowing down the work unit store type to a request store. This allows us to delete the function, and call `throwForMissingRequestStore()` directly instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The places in which we called
getExpectedRequestStore()were already narrowing down the work unit store type to a request store. This allows us to delete the function, and callthrowForMissingRequestStore()directly instead.