-
Notifications
You must be signed in to change notification settings - Fork 29.3k
docs: clarify middleware location #83465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
docs: clarify middleware location #83465
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Addressed; reworded note and kept style consistent. Happy to adjust further. |
3db1fab
to
83032c7
Compare
Docs-only change; local lint/build OK. Fork-protected CI jobs failing are expected. Ready for review. |
Docs-only; local |
Hi, thanks for the PR. We mention already both in the Getting Started section, and API reference.
We also don't use emojis. |
Updated: removed emojis and avoided duplication. Kept a single note with a link to the existing convention. Local |
83032c7
to
2be7912
Compare
Replied in-thread here: #49607 (reply in thread). Keeping this PR docs-only and emoji-free. Local lint/build are green. |
I think we'll close this PR.
PR comment that links to totally unrelated thread (I think?) |
Clarifies where
middleware.{js,ts}
must live./middleware.ts
or/src/middleware.ts
/app/middleware.ts
(not loaded)Motivation: this path causes frequent confusion.
Local checks:
pnpm -w run lint
andpnpm -w run build
passed.Fork-protected jobs failing in CI are expected on forks.